Bug 200931 - [PATCH] security/keepass: Make xsel optional
Summary: [PATCH] security/keepass: Make xsel optional
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Pawel Pekala
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-06-17 09:04 UTC by Sascha Holzleiter
Modified: 2015-06-26 19:49 UTC (History)
2 users (show)

See Also:
woodsb02: maintainer-feedback+

Attachments
XSEL option patch (811 bytes, patch)
2015-06-17 09:04 UTC, Sascha Holzleiter 		no flags Details | Diff
Patch to convert xdotool and xsel runtime dependencies to options (927 bytes, patch)
2015-06-17 15:04 UTC, Ben Woods 		woodsb02: maintainer-approval+
Details | Diff
Successful poudriere testport logs with options xsel=on and xdotool=on (58.53 KB, text/plain)
2015-06-17 15:11 UTC, Ben Woods 		no flags Details
Successful poudriere testport logs with options xsel=off and xdotool=off (56.64 KB, text/plain)
2015-06-17 15:12 UTC, Ben Woods 		no flags Details
Successful poudriere testport logs with options xsel=off and xdotool=on (57.36 KB, text/plain)
2015-06-17 15:12 UTC, Ben Woods 		no flags Details
Successful poudriere testport logs with options xsel=on and xdotool=off (57.84 KB, text/plain)
2015-06-17 15:12 UTC, Ben Woods 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Holzleiter 2015-06-17 09:04:29 UTC 
Created attachment 157829 [details]
XSEL option patch

For me and others i know of the installation of the xsel dependency keeps KeePass from working. Maybe it's the desktop environment or something else but with xsel i get only an empty clipboard when copying usernames or passwords. Without xsel everything works as expected.

So I propose to make xsel an optional dependency. The following patch does exactly that and sets the option as default so the default behavior of the port does not change.
Comment 1 Ben Woods freebsd_committer freebsd_triage 2015-06-17 15:04:59 UTC 
Created attachment 157832 [details]
Patch to convert xdotool and xsel runtime dependencies to options

Thanks for your feedback. I have made a slight improvement on your proposal to also convert the xdotool runtime dependency to an option.

Other than that, I have tested that this works and am happy for this change to be committed.
Comment 2 Ben Woods freebsd_committer freebsd_triage 2015-06-17 15:11:31 UTC 
Created attachment 157833 [details]
Successful poudriere testport logs with options xsel=on and xdotool=on
Comment 3 Ben Woods freebsd_committer freebsd_triage 2015-06-17 15:12:00 UTC 
Created attachment 157834 [details]
Successful poudriere testport logs with options xsel=off and xdotool=off
Comment 4 Ben Woods freebsd_committer freebsd_triage 2015-06-17 15:12:27 UTC 
Created attachment 157835 [details]
Successful poudriere testport logs with options xsel=off and xdotool=on
Comment 5 Ben Woods freebsd_committer freebsd_triage 2015-06-17 15:12:50 UTC 
Created attachment 157836 [details]
Successful poudriere testport logs with options xsel=on and xdotool=off
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-06-26 19:49:44 UTC 
A commit references this bug:

Author: pawel
Date: Fri Jun 26 19:49:16 UTC 2015
New revision: 390665
URL: https://svnweb.freebsd.org/changeset/ports/390665

Log:
  - Make xsel run dependency optional - it makes clipboard pasting
    not working under some conditions [1]
  - Make xdotool also optional
  - Add NO_ARCH

  PR:		200931 [1]
  Submitted by:	Sascha Holzleiter <sascha@root-login.org> [1]
  Approved by:	maintainer [1]

Changes:
  head/security/keepass/Makefile