Created attachment 158351 [details] science/py-scikit-sparse: Use print function in test_cholmod The stage target fails with: ==== byte-compiling /wrkdirs/usr/ports/science/py-scikit-sparse/work/stage/usr/local/lib/python3.4/site-packages/scikits/sparse/test_cholmod.py to test_cholmod.cpython-34.pyc writing byte-compilation script '/tmp/tmpu41n5nsp.py' /usr/local/bin/python3.4 -O /tmp/tmpu41n5nsp.py File "/usr/local/lib/python3.4/site-packages/scikits/sparse/test_cholmod.py", line 56 print "dense" ^ SyntaxError: Missing parentheses in call to 'print' ==== The cause is self-explanatory. The attached patch corrects this and allows this port to be built under python 3. While here, update WWW in pkg-descr to match the README and the redirect from Google Code. Note: I tried to interact properly with the maintainer feedback flags on this bug, but got a variety of nonsensical, inconsistent errors, so I gave up and submitted it without setting the maintainer feedback flag at all, even though I know it should be set.
Approved, thanks!
*** Bug 201343 has been marked as a duplicate of this bug. ***
*** Bug 201344 has been marked as a duplicate of this bug. ***
*** Bug 201345 has been marked as a duplicate of this bug. ***
Upstreamed already. Nice! https://github.com/njsmith/scikits-sparse/pull/12
Thanks John, do you have QA results to attach? (portlint, poudriere)
Hey Koobs, % portlint -AC WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. WARN: Makefile: new ports should not set PORTREVISION. WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX. WARN: Makefile: wrong dependency value for BUILD_DEPENDS. BUILD_DEPENDS requires 2 or 3 colon-separated tuples. 0 fatal errors and 4 warnings found. poudriere testport output on its way shortly.
Thanks John, QA results as attachments please :) If you'd like bonus points, add upstream issue/pr references to the patch header as a comment
Created attachment 158356 [details] poudriere testport log for py27-scikit-sparse-0.2_1
Created attachment 158357 [details] poudriere testport log for py34-scikit-sparse-0.2_1
Created attachment 158358 [details] science/py-scikit-sparse: Use print function in test_cholmod It's as if you were grooming me for a commit bit or something. :-P How many bonus points do I get?
s/points/gold star! :)
I suggest we should close this bug because the next release will bring in the fix. USES=python:2 can be set in the meantime. If this really matters for the submitter, he can put this patch into his local ports tree.
If the current quarterly branch is affected, than the changes needed to fix it should be committed, and merged there too (if USES:python:2.7 does indeed resolve the issue)
A commit references this bug: Author: riggs Date: Sun Jul 26 15:11:41 UTC 2015 New revision: 392924 URL: https://svnweb.freebsd.org/changeset/ports/392924 Log: - Fix build when using python 3.x - Update WWW in pkg-descr, points to new project location now PR: 201346 Submitted by: john@saltant.com Approved by: yuri@rawbw.com (maintainer) MFH: 2015Q3 Changes: head/science/py-scikit-sparse/Makefile head/science/py-scikit-sparse/files/ head/science/py-scikit-sparse/files/patch-scikits_sparse_test__cholmod.py head/science/py-scikit-sparse/pkg-descr
A commit references this bug: Author: riggs Date: Sun Jul 26 15:15:58 UTC 2015 New revision: 392925 URL: https://svnweb.freebsd.org/changeset/ports/392925 Log: MFH: r392924 - Fix build when using python 3.x - Update WWW in pkg-descr, points to new project location now PR: 201346 Submitted by: john@saltant.com Approved by: ports-secteam (build fix blanket), yuri@rawbw.com (maintainer) Changes: _U branches/2015Q3/ branches/2015Q3/science/py-scikit-sparse/Makefile branches/2015Q3/science/py-scikit-sparse/files/ branches/2015Q3/science/py-scikit-sparse/pkg-descr
Committed this fix for now, until a new version is released upstream.