Bug 201450 - lang/v8: lang/v8-devel: unicode-decoder denial of service
Summary: lang/v8: lang/v8-devel: unicode-decoder denial of service
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-10 01:49 UTC by Jason Unovitch
Modified: 2015-07-29 17:38 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)


Attachments
security/vuxml update for the CVE-2015-5380 entry to include v8 and v8-devel (1.24 KB, patch)
2015-07-10 01:49 UTC, Jason Unovitch
no flags Details | Diff
v8 vuxml version range correction (363 bytes, patch)
2015-07-13 01:19 UTC, Jason Unovitch
no flags Details | Diff
backport CVE fix (4.38 KB, patch)
2015-07-29 13:55 UTC, Mark Felder
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Unovitch freebsd_committer freebsd_triage 2015-07-10 01:49:01 UTC
Created attachment 158577 [details]
security/vuxml update for the CVE-2015-5380 entry to include v8 and v8-devel

v8 has been added to the CVE-2015-5380 entry for the unicode-decoder denial of service

Reference:  https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-5380
Reference:  https://codereview.chromium.org/1226493003
Comment 1 Jason Unovitch freebsd_committer freebsd_triage 2015-07-10 01:51:07 UTC
Comment on attachment 158577 [details]
security/vuxml update for the CVE-2015-5380 entry to include v8 and v8-devel

From https://github.com/v8/v8-git-mirror/blob/master/ChangeLog, version 4.5.2 was the last release in May while the issue was fixed in the past few days.  Match the NVD entry right now by just specifying range greater than 0.
Comment 2 Mark Felder freebsd_committer freebsd_triage 2015-07-10 13:41:06 UTC
perhaps instead of <ge>0</ge> you can use <le>3.27.7_2</le> so it doesn't need to be edited again in the future

(I made the same mistake the other day)
Comment 3 Jason Unovitch freebsd_committer freebsd_triage 2015-07-10 15:15:07 UTC
(In reply to Mark Felder from comment #2)
Good call. I'll remember that for the next time and fix it later when I'm not on my phone.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-07-12 22:30:50 UTC
A commit references this bug:

Author: feld
Date: Sun Jul 12 22:30:26 UTC 2015
New revision: 391847
URL: https://svnweb.freebsd.org/changeset/ports/391847

Log:
  CVE-2015-5380 also affects v8 and v8-devel

  PR:		201450
  Security:	864e6f75-2372-11e5-86ff-14dae9d210b8
  Security:	CVE-2015-5380

Changes:
  head/security/vuxml/vuln.xml
Comment 5 Jason Unovitch freebsd_committer freebsd_triage 2015-07-13 01:19:47 UTC
Created attachment 158675 [details]
v8 vuxml version range correction

(In reply to Mark Felder from comment #2)
Sorry for the delay.  Thanks for fixing the version.  Another patch is attached to accommodate this with the correct version for both lang/v8 and lang/v8-devel.

Also, I agree in concept but it's hypothetically possible that a PORTREVISION bump for an unrelated fix like a shared library bump could end up fooling the version check and give a false sense of security if we or the maintainer doesn't keep an eye on it.  I know that won't be an issue here but it's something to consider.
Comment 6 Jason Unovitch freebsd_committer freebsd_triage 2015-07-13 01:20:15 UTC
Reset to open until port has been updated.
Comment 7 Jason Unovitch freebsd_committer freebsd_triage 2015-07-13 01:21:09 UTC
Comment on attachment 158577 [details]
security/vuxml update for the CVE-2015-5380 entry to include v8 and v8-devel

Variant committed.  Obsolete this to reduce PR clutter.
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-07-13 04:09:33 UTC
A commit references this bug:

Author: feld
Date: Mon Jul 13 04:08:33 UTC 2015
New revision: 391876
URL: https://svnweb.freebsd.org/changeset/ports/391876

Log:
  Correct range for non-devel version of v8

  PR:		201450
  Security:	864e6f75-2372-11e5-86ff-14dae9d210b8

Changes:
  head/security/vuxml/vuln.xml
Comment 9 Mark Felder freebsd_committer freebsd_triage 2015-07-13 04:13:31 UTC
I guess we now wait for sunpoet. It appears we use local distfiles. I looked at the v8 github and they seem to tag a release every few commits or something and they're on 4.6.1 now which seems to be far ahead of this v8 port. 

I'm not familiar with v8 at all so I'll let someone with a clue sort this out. Hopefully this can be solved soon.
Comment 10 Will Green 2015-07-29 11:54:50 UTC
Just to note that this is a dependency of databases/mongodb (amongst others), so I imagine a relatively large number of people are affected.
Comment 11 Mark Felder freebsd_committer freebsd_triage 2015-07-29 13:33:14 UTC
Sunpoet, do you have any cycles available to work on this? I have patch that backports the fix, but I'm not sure if we want to do that vs upgrading v8
Comment 12 Mark Felder freebsd_committer freebsd_triage 2015-07-29 13:55:39 UTC
Created attachment 159365 [details]
backport CVE fix
Comment 13 commit-hook freebsd_committer freebsd_triage 2015-07-29 16:41:48 UTC
A commit references this bug:

Author: feld
Date: Wed Jul 29 16:41:11 UTC 2015
New revision: 393181
URL: https://svnweb.freebsd.org/changeset/ports/393181

Log:
  devel/v8, devel/v8-devel: Backport CVE fix

  This fix has been backported instead of upgrading to a newer release as
  the upstream release process is a complicated fast-moving target and the
  current ports are using custom snapshots created by the port maintainer.

  This will also limit the amount of potential fallout as we know the
  existing v8 port works well enough to keep mongodb up to date.

  PR:		201450
  MFH:		2015Q3
  Security:	CVE-2015-5380
  Security:	864e6f75-2372-11e5-86ff-14dae9d210b8

Changes:
  head/devel/v8/
  head/devel/v8/files/
  head/devel/v8/files/patch-CVE-2015-5380
  head/devel/v8-devel/
  head/devel/v8-devel/files/
  head/devel/v8-devel/files/patch-CVE-2015-5380
Comment 14 commit-hook freebsd_committer freebsd_triage 2015-07-29 16:43:50 UTC
A commit references this bug:

Author: feld
Date: Wed Jul 29 16:43:33 UTC 2015
New revision: 393182
URL: https://svnweb.freebsd.org/changeset/ports/393182

Log:
  MFH: r393181

  devel/v8, devel/v8-devel: Backport CVE fix

  This fix has been backported instead of upgrading to a newer release as
  the upstream release process is a complicated fast-moving target and the
  current ports are using custom snapshots created by the port maintainer.

  This will also limit the amount of potential fallout as we know the
  existing v8 port works well enough to keep mongodb up to date.

  PR:		201450
  Security:	CVE-2015-5380
  Security:	864e6f75-2372-11e5-86ff-14dae9d210b8
  Approved by:	ports-secteam (with hat)

Changes:
_U  branches/2015Q3/
  branches/2015Q3/devel/v8/
  branches/2015Q3/devel/v8-devel/
Comment 15 Mark Felder freebsd_committer freebsd_triage 2015-07-29 16:45:06 UTC
I've backported the patch to keep this from continuing to be a blocker for people trying to install/use mongodb.
Comment 16 commit-hook freebsd_committer freebsd_triage 2015-07-29 17:00:53 UTC
A commit references this bug:

Author: feld
Date: Wed Jul 29 17:00:31 UTC 2015
New revision: 393186
URL: https://svnweb.freebsd.org/changeset/ports/393186

Log:
  lang/v8, lang/v8-devel: Backport CVE fix

  This fix has been backported instead of upgrading to a newer release as
  the upstream release process is a complicated fast-moving target and the
  current ports are using custom snapshots created by the port maintainer.

  This will also limit the amount of potential fallout as we know the
  existing v8 port works well enough to keep mongodb up to date.

  PR:		201450
  MFH:		2015Q3
  Security:	CVE-2015-5380
  Security:	864e6f75-2372-11e5-86ff-14dae9d210b8

Changes:
  head/lang/v8/Makefile
  head/lang/v8/files/
  head/lang/v8/files/patch-CVE-2015-5380
  head/lang/v8-devel/Makefile
  head/lang/v8-devel/files/patch-CVE-2015-5380
Comment 17 commit-hook freebsd_committer freebsd_triage 2015-07-29 17:01:55 UTC
A commit references this bug:

Author: feld
Date: Wed Jul 29 17:01:45 UTC 2015
New revision: 393187
URL: https://svnweb.freebsd.org/changeset/ports/393187

Log:
  MFH: r393186

  lang/v8, lang/v8-devel: Backport CVE fix

  This fix has been backported instead of upgrading to a newer release as
  the upstream release process is a complicated fast-moving target and the
  current ports are using custom snapshots created by the port maintainer.

  This will also limit the amount of potential fallout as we know the
  existing v8 port works well enough to keep mongodb up to date.

  PR:		201450
  Security:	CVE-2015-5380
  Security:	864e6f75-2372-11e5-86ff-14dae9d210b8
  Approved by:	ports-secteam (with hat)

Changes:
_U  branches/2015Q3/
  branches/2015Q3/lang/v8/Makefile
  branches/2015Q3/lang/v8/files/
  branches/2015Q3/lang/v8-devel/Makefile
  branches/2015Q3/lang/v8-devel/files/patch-CVE-2015-5380
Comment 18 Will Green 2015-07-29 17:38:33 UTC
That's great news. I'll roll this out to our Mongo servers when the package is built.