Bug 201462 - [patch] security/libressl - Option to not install API manpages
Summary: [patch] security/libressl - Option to not install API manpages
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vsevolod Stakhov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-07-10 20:18 UTC by Adam Weinberger
Modified: 2016-01-05 09:20 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (vsevolod)


Attachments
API_MAN (110.53 KB, patch)
2015-07-10 20:18 UTC, Adam Weinberger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Weinberger freebsd_committer freebsd_triage 2015-07-10 20:18:28 UTC
Created attachment 158588 [details]
API_MAN

There are over 1,450 API-related manpages in the LibreSSL port's plist. For many (most?) users, they don't need or want these API manpages.

The attached patch adds an API_MAN option that controls whether manpages are installed. It's a simple patch that just does the work in the plist. It's on by default (meaning all manpages get installed) so the default package doesn't change. It also doesn't affect the man1 stuff, which more people are likely to use.

When using the API_MAN option, the number of files goes down to less than 100, a reduction of 94%. I submitted a similar patch for the openssl port (bug #201459). As I said in that PR, adding in this option won't stop the sky from falling, but it'd be a nice option to give to users.
Comment 1 Adam Weinberger freebsd_committer freebsd_triage 2015-11-19 00:51:13 UTC
I'm going to close this PR, as the requested change was committed with r399426.
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-01-04 13:55:25 UTC
A commit references this bug:

Author: brnrd
Date: Mon Jan  4 13:54:39 UTC 2016
New revision: 405241
URL: https://svnweb.freebsd.org/changeset/ports/405241

Log:
  security/libressl-devel: Add next-stable LibreSSL 2.3 port

    - Add security/libressl-devel for version 2.3.1
    - Including corrections for CVE-2015-3194/3195
    - Add support for multiple versions to bsd.openssl.mk
    - Add option to optionally install API man-pages (201462)
    - Disable silent rules output

  Changes:

    - ftp://ftp.openbsd.org/pub/OpenBSD/LibreSSL/libressl-2.3.0-relnotes.txt
    - ftp://ftp.openbsd.org/pub/OpenBSD/LibreSSL/libressl-2.3.1-relnotes.txt

  PR:		201462
  Submitted by: 	adamw (201462)
  Reviewed by:	vsevolod (mentor, maintainer), koobs (mentor), feld (mentor)
  Approved by:	koobs (mentor), feld (mentor)
  Differential Revision:	https://reviews.freebsd.org/D3585

Changes:
  head/Mk/bsd.openssl.mk
  head/security/libressl-devel/
  head/security/libressl-devel/Makefile
  head/security/libressl-devel/distinfo
  head/security/libressl-devel/files/
  head/security/libressl-devel/files/patch-crypto_asn1_tasn__dec.c
  head/security/libressl-devel/files/patch-crypto_rsa_rsa__ameth.c
  head/security/libressl-devel/files/patch-include_openssl_opensslv.h
  head/security/libressl-devel/pkg-descr
  head/security/libressl-devel/pkg-message
  head/security/libressl-devel/pkg-plist
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-01-05 09:20:05 UTC
A commit references this bug:

Author: brnrd
Date: Tue Jan  5 09:19:45 UTC 2016
New revision: 405278
URL: https://svnweb.freebsd.org/changeset/ports/405278

Log:
  security/libressl-devel: Add next-stable LibreSSL 2.3 port

    - Add security/libressl-devel for version 2.3.1
    - Repository copy of security/libressl [1]
    - Including corrections for CVE-2015-3194/3195
    - Add support for multiple versions to bsd.openssl.mk
    - Add option to optionally install API man-pages [2]
    - Disable silent rules output

  Changes:

    - ftp://ftp.openbsd.org/pub/OpenBSD/LibreSSL/libressl-2.3.0-relnotes.txt
    - ftp://ftp.openbsd.org/pub/OpenBSD/LibreSSL/libressl-2.3.1-relnotes.txt

  PR:		201462 [2]
  Submitted by: 	adamw [2]
  Requested by:	junovitch [1]
  Reviewed by:	vsevolod (mentor, maintainer), koobs (mentor), feld (mentor)
  Approved by:	koobs (mentor), feld (mentor), mat [1] (portmgr)
  Differential Revision:	https://reviews.freebsd.org/D3585

Changes:
  head/security/libressl-devel/
  head/security/libressl-devel/Makefile
  head/security/libressl-devel/distinfo
  head/security/libressl-devel/files/patch-crypto_asn1_tasn__dec.c
  head/security/libressl-devel/files/patch-crypto_rsa_rsa__ameth.c
  head/security/libressl-devel/files/patch-include_openssl_opensslv.h
  head/security/libressl-devel/pkg-plist