Bug 201486 - [patch] games/minetest_game: add NO_ARCH, fix some libpng warnings
Summary: [patch] games/minetest_game: add NO_ARCH, fix some libpng warnings
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-07-11 23:34 UTC by Andriy Voskoboinyk
Modified: 2015-07-14 15:59 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (amdmi3)

Attachments
Makefile.diff (1.14 KB, patch)
2015-07-11 23:34 UTC, Andriy Voskoboinyk 		no flags Details | Diff
portlint.log (209 bytes, text/plain)
2015-07-11 23:35 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-9.3-i386.log (18.62 KB, text/plain)
2015-07-11 23:36 UTC, Andriy Voskoboinyk 		no flags Details
Makefile2.diff (353 bytes, patch)
2015-07-14 15:37 UTC, Andriy Voskoboinyk 		avos: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-11 23:34:31 UTC 
Created attachment 158632 [details]
Makefile.diff

- Add NO_ARCH=yes.
- Use mogrify from graphics/ImageMagick for fixing "PNG warning: iCCP: RGB color space not permitted on grayscale PNG" and "PNG warning: iCCP: known incorrect sRGB profile" runtime warnings.
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-11 23:35:39 UTC 
Created attachment 158633 [details]
portlint.log
Comment 2 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-11 23:36:42 UTC 
Created attachment 158634 [details]
poudriere-9.3-i386.log
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2015-07-13 17:36:15 UTC 
I don't see a point of adding extra build dependency just to silence warnings, so you're better to address this issue upstream: https://github.com/minetest/minetest_game. NO_ARCH addition is good.
Comment 4 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-14 15:37:19 UTC 
Created attachment 158754 [details]
Makefile2.diff
Comment 5 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-14 15:45:53 UTC 
(In reply to Dmitry Marakasov from comment #3)
> I don't see a point of adding extra build dependency just to silence warnings,
> so you're better to address this issue upstream: https://github.com/minetest/minetest_game.

Ok (these warnings were already fixed in upstream).
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-07-14 15:59:38 UTC 
A commit references this bug:

Author: amdmi3
Date: Tue Jul 14 15:58:53 UTC 2015
New revision: 392031
URL: https://svnweb.freebsd.org/changeset/ports/392031

Log:
  - Add NO_ARCH

  PR:		201486
  Submitted by:	s3erios@gmail.com

Changes:
  head/games/minetest_game/Makefile