Bug 201662 - [patch] games/chessx: qt4-linguist -> qt4-linguisttools, pet portlint
Summary: [patch] games/chessx: qt4-linguist -> qt4-linguisttools, pet portlint
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Philip M. Gollucci
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-07-17 21:44 UTC by Andriy Voskoboinyk
Modified: 2015-08-12 00:18 UTC (History)
1 user (show)

See Also:
avos: maintainer-feedback+

Attachments
Patch.diff (2.26 KB, patch)
2015-07-17 21:44 UTC, Andriy Voskoboinyk 		no flags Details | Diff
portlint.log (130 bytes, text/plain)
2015-07-17 21:45 UTC, Andriy Voskoboinyk 		no flags Details
poudriere-10.1-amd64.log (235.38 KB, text/plain)
2015-07-17 21:45 UTC, Andriy Voskoboinyk 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-17 21:44:25 UTC 
Created attachment 158917 [details]
Patch.diff

- USE_QT4=linguist_build -> USE_QT4=linguisttools_build.
- Remove qt4-xml dependency - it's not used here.
- Add LICENSE_FILE.
- Fix portlint warnings:
-- sort USES;
-- use PLIST_FILES instead of pkg-plist;
-- regenerate patch headers.
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-17 21:45:38 UTC 
Created attachment 158918 [details]
portlint.log
Comment 2 Andriy Voskoboinyk freebsd_committer freebsd_triage 2015-07-17 21:45:56 UTC 
Created attachment 158919 [details]
poudriere-10.1-amd64.log
Comment 3 Philip M. Gollucci freebsd_committer freebsd_triage 2015-07-18 00:48:12 UTC 
Take.
Comment 4 yamagi 2015-07-18 05:56:00 UTC 
The patch looks good to me. Go ahead :)
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-08-12 00:12:41 UTC 
A commit references this bug:

Author: pgollucci
Date: Wed Aug 12 00:12:21 UTC 2015
New revision: 393993
URL: https://svnweb.freebsd.org/changeset/ports/393993

Log:
  games/chessx: cleanup

  - USE_QT4=linguist_build -> USE_QT4=linguisttools_build.
  - Remove qt4-xml dependency - it's not used here.
  - Add LICENSE_FILE.
  - Bump PORTREVISION.
  - Fix portlint warnings:
    sort USES;
    use PLIST_FILES instead of pkg-plist;
    regenerate patch headers.

  PR:                  201662
  Submitted by:        s3erios@gmail.com
  Approved by:         yamagi@yamagi.org (maintainer)

Changes:
  head/games/chessx/Makefile
  head/games/chessx/files/patch-chessx.pro
  head/games/chessx/files/patch-src__database__threadedguess.cpp
  head/games/chessx/pkg-plist
Comment 6 Philip M. Gollucci freebsd_committer freebsd_triage 2015-08-12 00:18:02 UTC 
Committed, Thanks!