Bug 201948 - archivers/libarchive: remove LIBXML2 option
Summary: archivers/libarchive: remove LIBXML2 option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Greg Lewis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-28 18:17 UTC by Tijl Coosemans
Modified: 2015-07-29 13:44 UTC (History)
0 users

See Also:
glewis: maintainer-feedback+


Attachments
patch (1.59 KB, patch)
2015-07-28 18:17 UTC, Tijl Coosemans
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tijl Coosemans freebsd_committer freebsd_triage 2015-07-28 18:17:36 UTC
Created attachment 159342 [details]
patch

The LIBXML2 option adds a dependency on libxml2 but it also adds -lbsdxml to LDFLAGS but the two are mutually exclusive.  Moreover, libbsdxml is a private copy of libexpat that is not supposed to be used outside the base system.  The attached patch removes the LIBXML2 option and replaces it with a simple dependency on libexpat from textproc/expat2.

The patch also removes PATCH_STRIP because there are no patches and replaces MAKE with MAKE_CMD.
Comment 1 Greg Lewis freebsd_committer freebsd_triage 2015-07-29 12:55:50 UTC
Looks good to me.  Feel free to commit.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-07-29 13:39:22 UTC
A commit references this bug:

Author: tijl
Date: Wed Jul 29 13:39:13 UTC 2015
New revision: 393159
URL: https://svnweb.freebsd.org/changeset/ports/393159

Log:
  Libarchive can use either libxml2 or libexpat for xar support, but the
  LIBXML2 option currently makes libarchive link to both libxml2 and
  libbsdxml (base system private copy of libexpat).  Replace this with a
  simple depdendency on libexpat.

  Also remove PATCH_STRIP because there are no patches, replace MAKE with
  MAKE_CMD and add INSTALL_TARGET=install-strip.

  PR:		201948
  Approved by:	glewis (maintainer)

Changes:
  head/archivers/libarchive/Makefile