Bug 202238 - [MAINTAINER] net-im/corebird: update to 1.0.1, add NLS option, fix video playback
Summary: [MAINTAINER] net-im/corebird: update to 1.0.1, add NLS option, fix video play...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Olivier Duchateau
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-11 02:41 UTC by Carlos J Puga Medina
Modified: 2015-08-14 19:16 UTC (History)
1 user (show)

See Also:

Attachments
Patch (5.89 KB, patch)
2015-08-11 02:41 UTC, Carlos J Puga Medina 		no flags Details | Diff
Patch (6.82 KB, patch)
2015-08-11 23:09 UTC, Carlos J Puga Medina 		no flags Details | Diff
Fix video support (4.30 KB, patch)
2015-08-13 19:37 UTC, Olivier Duchateau 		no flags Details | Diff
Patch (3.71 KB, patch)
2015-08-14 18:18 UTC, Carlos J Puga Medina 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J Puga Medina 2015-08-11 02:41:37 UTC 
Created attachment 159750 [details]
Patch

- Update to 1.0.1
- Clean-up Makefile
- Add NLS option
- Fix pkg-plist
Comment 1 Olivier Duchateau freebsd_committer freebsd_triage 2015-08-11 20:21:31 UTC 
I'll take it
Comment 2 Carlos J Puga Medina 2015-08-11 23:09:08 UTC 
Created attachment 159785 [details]
Patch

Fix video playback
Comment 3 Olivier Duchateau freebsd_committer freebsd_triage 2015-08-13 19:37:11 UTC 
Created attachment 159848 [details]
Fix video support

In your previous patches, support of Vaapi is missing, I added it.

I also removed NLS option, because locales files are always installed, even if this option is unset (configure.ac script must be patched).
Comment 4 Carlos J Puga Medina 2015-08-14 00:43:41 UTC 
(In reply to Olivier Duchateau from comment #3)

It's OK!

Thanks, olivierd@
Comment 5 Carlos J Puga Medina 2015-08-14 01:42:33 UTC 
It's weird, but in my case video playback works only using 'xvimagesink'.

% uname -a
FreeBSD bsd.nix 10.2-RELEASE FreeBSD 10.2-RELEASE #0 r286666: Wed Aug 12 15:26:37 UTC 2015     root@releng1.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC  amd64

olivierd@, did you have this behaviour?
Comment 6 Olivier Duchateau freebsd_committer freebsd_triage 2015-08-14 03:28:40 UTC 
(In reply to Carlos J Puga Medina from comment #5)

Not tested video support, but in src/widgets/MediaVideoWidget.vala you replace 'xvimagesink' by 'vaapisink'. This sink element is provided by multimedia/gstreamer1-vaapi plugin. So for me vaapi support is missing.
Comment 7 Carlos J Puga Medina 2015-08-14 18:12:25 UTC 
Well, it was modified upstream 

https://github.com/baedert/corebird/commit/ad9f431bc66913f786a815838e3c1b231d71acc5

We can delete this patch safely for now.
Comment 8 Carlos J Puga Medina 2015-08-14 18:18:41 UTC 
Created attachment 159869 [details]
Patch
Comment 9 commit-hook freebsd_committer freebsd_triage 2015-08-14 19:14:05 UTC 
A commit references this bug:

Author: olivierd
Date: Fri Aug 14 19:13:23 UTC 2015
New revision: 394252
URL: https://svnweb.freebsd.org/changeset/ports/394252

Log:
  Update to 1.0.1

  PR:		202238
  Submitted by:	Carlos Puga Medina (maintainer)

Changes:
  head/net-im/corebird/Makefile
  head/net-im/corebird/distinfo
  head/net-im/corebird/files/patch-Makefile.am
  head/net-im/corebird/files/patch-configure.ac
  head/net-im/corebird/files/patch-data__Makefile.am
Comment 10 Olivier Duchateau freebsd_committer freebsd_triage 2015-08-14 19:16:01 UTC 
Committed, thanks.