Bug 202244 - [MAINTAINER] security/keepass: Update to 2.30
Summary: [MAINTAINER] security/keepass: Update to 2.30
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason Unovitch
URL: http://keepass.info/news/n150809_2.30...
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-11 13:43 UTC by Ben Woods
Modified: 2015-08-18 00:33 UTC (History)
2 users (show)

See Also:
woodsb02: maintainer-feedback+


Attachments
Patch to update security/keepass to 2.30 (900 bytes, patch)
2015-08-11 13:43 UTC, Ben Woods
no flags Details | Diff
QA: Successful poudriere testport logs on FreeBSD 11-current amd64 (59.01 KB, text/plain)
2015-08-11 14:30 UTC, Ben Woods
no flags Details
Screenshot showing KeePass 2.30 running on FreeBSD 10.2 in XFCE (150.53 KB, image/png)
2015-08-17 13:25 UTC, Ben Woods
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Woods freebsd_committer freebsd_triage 2015-08-11 13:43:07 UTC
Created attachment 159767 [details]
Patch to update security/keepass to 2.30

Patch attached to update security/keepass to the latest upstream release 2.30.
Comment 1 Ben Woods freebsd_committer freebsd_triage 2015-08-11 14:30:35 UTC
Created attachment 159769 [details]
QA: Successful poudriere testport logs on FreeBSD 11-current amd64
Comment 2 Jason Unovitch freebsd_committer freebsd_triage 2015-08-12 02:33:48 UTC
(In reply to Ben Woods from comment #1)
Hello Ben,
Thanks for your work.  I'm going to need some time to review this as I am seeing a runtime error.  Any input would be appreciated as I don't know if this is something tied to an interaction with the version of CURRENT on my machine or if this is related to keepass.

Unhandled Exception:
System.IO.IOException: persistent kevent() error, error code = '22'
  at System.IO.KqueueMonitor.Monitor () [0x00000] in <filename unknown>:0 
  at System.IO.KqueueMonitor.DoMonitor () [0x00000] in <filename unknown>:0 
[ERROR] FATAL UNHANDLED EXCEPTION: System.IO.IOException: persistent kevent() error, error code = '22'
  at System.IO.KqueueMonitor.Monitor () [0x00000] in <filename unknown>:0 
  at System.IO.KqueueMonitor.DoMonitor () [0x00000] in <filename unknown>:0
Comment 3 Ben Woods freebsd_committer freebsd_triage 2015-08-17 13:22:10 UTC
Hi Jason,

Sorry for the delay in responding, but I was away from home and couldn't test this more until I got back.

I have just tested it on my FreeBSD 10.2 i386 laptop, and it worked fine for me. I will attach screenshots to prove it.

However, I note that a few people are also experiencing the error you reported when trying to run graphical mono applications (it doesn't seem to be specific to keepass):
https://bugzilla.xamarin.com/show_bug.cgi?id=32782
https://forums.freebsd.org/threads/keepass-2-29-crashes.52554/
https://lists.freebsd.org/pipermail/freebsd-mono/2015-August/001821.html

I suspect the existing security/keepass port version 2.29 will not work for you either? If this is the case, would you be able to commit this update based on the following screenshots showing this does work on my FreeBSD installation, and we can continue to work with the mono team to work out the cause of this issue?
Comment 4 Ben Woods freebsd_committer freebsd_triage 2015-08-17 13:25:27 UTC
Created attachment 159957 [details]
Screenshot showing KeePass 2.30 running on FreeBSD 10.2 in XFCE
Comment 5 Jason Unovitch freebsd_committer freebsd_triage 2015-08-18 00:22:38 UTC
(In reply to Ben Woods from comment #3)

Hi Ben,
Thanks! I will try to commit this shortly.

You were indeed correct and Keepass 2.29 had issues as well.  Updating to Mono 4.0.3.20 has alleviated the runtime issues.  The lang/mono update hit ports recently:
https://svnweb.FreeBSD.org/changeset/ports/394390

I looked into the Mono kqueue brokenness and saw bug 198727 for it.  If the pull requests you mentioned in https://bugs.FreeBSD.org/bugzilla/show_bug.cgi?id=198727#c3 have been fixed as part of that Mono update I would greatly appreciate it if you can follow up and help get that PR closed out.
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-08-18 00:31:58 UTC
A commit references this bug:

Author: junovitch
Date: Tue Aug 18 00:31:31 UTC 2015
New revision: 394536
URL: https://svnweb.freebsd.org/changeset/ports/394536

Log:
  security/keepass: update 2.29 -> 2.30

  PR:		202244
  Submitted by:	Ben Woods <woodsb02@gmail.com> (maintainer)
  Approved by:	delphij (mentor)

Changes:
  head/security/keepass/Makefile
  head/security/keepass/distinfo
Comment 7 Jason Unovitch freebsd_committer freebsd_triage 2015-08-18 00:33:16 UTC
Committed. Thanks again Ben!