Created attachment 159904 [details] 4.21 Attached patch updates p5-EV to 4.21. files/patch-libev__ev.c should be removed. Changes: https://metacpan.org/changes/distribution/EV
Created attachment 160289 [details] Fixed patch for EV 4.21 Thank you for the patch! I attach slightly modified version with 2 changes: 1. It is a full patch (output of svn diff command) 2. I prefer to not touch author's dependencies, so do not remove usage of Canary::Stability module. Poudriere build log: http://poudriere.vovkasm.org/build.html?mastername=10-1-amd64-devel&build=2015-08-24_08h09m59s
Canary::Stability doesn't do anything. All it does is check which Perl version you're using. In EV, it checks whether you're using Perl > 5.08, and FreeBSD ports does not support anything remotely close to that old. It is a completely pointless dependency. All it does is print: *** *** The stability canary says: chirp! chirp! (it seems to be quite happy) *** *** Your version of perl ($]) is quite supported by $distname, nothing *** else to be said, hope it comes in handy. *** I suggest you reconsider adding the dependency purely for the sake of adding a dependency. Or consider turning it into an OPTION.
I think about it this way: = Case 1. Cut off Canary::Stability from Makefile.PL + Fewer dependencies. - Any changes in original sources can increase future maintenance work. - Canary::Stability can change in future to make more work (how to track this change?). = Case 2. Keep Makefile.PL as is. - Plus one dependent port. (Only at build time, though). + Minimum maintenance work. + If the author of EV changes the requirements, we will be notified automatically. + If the author changes Canary::Stability (with release of newer version of perl for ex.) we will be notified. Also. Canary::Stability not only check that version of Perl >= 5.080, it also warns, if Perl >= 5.022 (Because Coro [p5-Coro] can't work with modern perls). It also check authors own version of Perl - http://stableperl.schmorp.de/. Who knows if it will be ported also? So (and because Canary::Stability already ported), I'd prefer case 2. Do you have additional arguments for patching Makefile.PL? May be I forgot about something serious.
A commit references this bug: Author: adamw Date: Tue Aug 25 00:51:38 UTC 2015 New revision: 395196 URL: https://svnweb.freebsd.org/changeset/ports/395196 Log: Update to 4.21. Changes: https://metacpan.org/changes/distribution/EV PR: 202349 Approved by: Vladimir Timofeev (maintainer) Changes: head/devel/p5-EV/Makefile head/devel/p5-EV/distinfo head/devel/p5-EV/files/
Everything you said is correct, and respecting the author's intention is clearly the right thing to do. I shouldn't write PR comments before I've had coffee. I still feel like Canary::Stability is of pretty sketchy benefit at best, but I can't argue with Marc Lehmann's results... he makes some of the most useful Perl modules out there.
(In reply to Adam Weinberger from comment #5) Thank you! I also think that Canary::Stability is not the best solution. I would be happy if Mark and the other members of the Perl community could agree. But now it is unfortunately not possible.