Bug 202605 - audio/audacity: convert SSE to option helpers and PORTMIXER to target helpers
Summary: audio/audacity: convert SSE to option helpers and PORTMIXER to target helpers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-08-24 00:44 UTC by Jan Beich
Modified: 2015-08-24 08:32 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (xxjack12xx)

Attachments
v0 (2.04 KB, patch)
2015-08-24 00:44 UTC, Jan Beich 		no flags Details | Diff
QA: poudriere testport -j 93i386 (48.64 KB, application/x-gzip)
2015-08-24 02:27 UTC, Jan Beich 		no flags Details
QA: poudriere testport -j 93amd64 (48.83 KB, application/x-gzip)
2015-08-24 02:27 UTC, Jan Beich 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2015-08-24 00:44:29 UTC 
Created attachment 160275 [details]
v0

MACHINE_CPU check can be optimized away via OPTIONS_DEFAULT and powerpc conditional that required .include <bsd.port.pre.mk> is gone. The patch makes it possible to force-enable or force-disable SSE support regardless of CPUTYPE. By default i386 package remains without SSE, while amd64 with it. This also fixes a case when MACHINE_CPU is not defined e.g., for new architectures not in bsd.cpu.mk.

And take advantage of /usr/ports/CHANGES from 20150701.

Both make it possible to eliminate duplicate inclusion of bsd.port.mk.
Comment 1 Jack 2015-08-24 01:32:12 UTC 
Looks ok.
Comment 2 Jan Beich freebsd_committer freebsd_triage 2015-08-24 02:27:41 UTC 
Created attachment 160279 [details]
QA: poudriere testport -j 93i386
Comment 3 Jan Beich freebsd_committer freebsd_triage 2015-08-24 02:27:44 UTC 
Created attachment 160280 [details]
QA: poudriere testport -j 93amd64
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-08-24 08:30:38 UTC 
A commit references this bug:

Author: jbeich
Date: Mon Aug 24 08:30:18 UTC 2015
New revision: 395161
URL: https://svnweb.freebsd.org/changeset/ports/395161

Log:
  audio/audacity: convert to more option helpers

  - Restore SSE option removed in r331611
  - Keep SSE default only to amd64 or i386 + custom CPUTYPE
  - Convert PORTMIXER to target option helper

  PR:		202605
  Approved by:	xxjack12xx@gmail.com (maintainer)

Changes:
  head/audio/audacity/Makefile