Bug 202618 - [PATCH] databases/mysql56-client: Switch to USES=libedit
Summary: [PATCH] databases/mysql56-client: Switch to USES=libedit
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alex Dupre
URL:
Keywords: patch
Depends on:
Blocks: 202516
  Show dependency treegraph
 
Reported: 2015-08-24 11:21 UTC by Raphael Kubo da Costa
Modified: 2015-09-07 11:17 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (ale)


Attachments
Proposed patch (578 bytes, patch)
2015-08-24 11:21 UTC, Raphael Kubo da Costa
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-08-24 11:21:16 UTC
Instead of manually adding both a build- and a run-time dependency on libedit from ports, use USES=libedit instead. Not only does it take care of adding the proper dependency, but it also sets CMAKE_PREFIX_PATH to ${LOCALBASE} to make sure that the version in ports is preferred instead of the one in base.

This is a dependency for moving to CMake 3.3.x, as starting with 3.3.0 calls to find_library() will also look in the $PATH environment variable and end up finding libedit from base by default (see bug 202516).
Comment 1 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-08-24 11:21:39 UTC
Created attachment 160303 [details]
Proposed patch
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-09-07 11:17:18 UTC
A commit references this bug:

Author: rakuco
Date: Mon Sep  7 11:16:17 UTC 2015
New revision: 396260
URL: https://svnweb.freebsd.org/changeset/ports/396260

Log:
  Switch to USES=libedit.

  Instead of manually adding both a build- and a run-time dependency on
  libedit from ports, use USES=libedit instead. Not only does it take care of
  adding the proper dependency, but it also sets CMAKE_PREFIX_PATH to
  ${LOCALBASE} to make sure that the version in ports is preferred instead of
  the one in base.

  This is a dependency for moving to CMake 3.3.x, as starting with 3.3.0 calls
  to find_library() will also look in the $PATH environment variable and end
  up finding libedit from base by default (see bug 202516).

  PR:		202618
  Approved by:	maintainer timeout (ale, 14 days)

Changes:
  head/databases/mysql56-server/Makefile