Bug 202760 - [PATCH] databases/xtrabackup: Drop USES=iconv.
Summary: [PATCH] databases/xtrabackup: Drop USES=iconv.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-08-29 21:48 UTC by Raphael Kubo da Costa
Modified: 2015-10-29 13:47 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (aleks)
koobs: merge-quarterly?

Attachments
Proposed patch (762 bytes, patch)
2015-08-29 21:48 UTC, Raphael Kubo da Costa 		no flags Details | Diff
Update to 2.2.12 (1.38 KB, patch)
2015-09-15 12:12 UTC, Thomas Babut 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-08-29 21:48:03 UTC 
Created attachment 160502 [details]
Proposed patch

xtrabackup itself makes no iconv calls and does not use any iconv header. The only usages that I could find are in the bundled libarchive, but it is built with expat instead of libxml2, so it ends up not being used at all.
Comment 1 Thomas Babut 2015-09-15 12:12:43 UTC 
Created attachment 161052 [details]
Update to 2.2.12

Could you please update the port to 2.2.12 at the same time? I have attached a patch including the suggested dependency change from Raphael.
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-09-17 13:22:06 UTC 
That works for me too. We'll just have to wait a little longer to land everything separately (the official period for a maintainer timeout is 14 days).
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-29 10:56:52 UTC 
The dropping of USES=iconv should probably be MFH'd, whereas the version update shouldn't
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-10-29 13:47:49 UTC 
A commit references this bug:

Author: mat
Date: Thu Oct 29 13:47:34 UTC 2015
New revision: 400459
URL: https://svnweb.freebsd.org/changeset/ports/400459

Log:
  Update to 2.2.12. [1]

  Remove unneeded bits from the past.

  PR:		202760
  Submitted by:	maintainer
  Sponsored by:	Absolight

Changes:
  head/databases/xtrabackup/Makefile
  head/databases/xtrabackup/distinfo