Bug 203307 - www/node: fails to build on FreeBSD 9.3-RELEASE because of dependency to gcc48 not enforced in Makefile
Summary: www/node: fails to build on FreeBSD 9.3-RELEASE because of dependency to gcc4...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kurt Jaeger
URL:
Keywords:
: 203370 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-09-24 11:47 UTC by François Charlier
Modified: 2015-10-01 17:48 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (linpct)

Attachments
Makefile patch (255 bytes, text/plain)
2015-09-24 11:47 UTC, François Charlier 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description François Charlier 2015-09-24 11:47:45 UTC 
Created attachment 161334 [details]
Makefile patch

www/node fails to build on FreeBSD 9.3-RELEASE because of dependency to gcc48 not enforced in Makefile.

The attached patch allows the port to build.
Comment 1 Chad Jacob Milios 2015-09-25 04:56:18 UTC 
+1
worked great for me, built and running my [albeit simple] app on node-4.1.1 on FreeBSD 9.3-RELEASE-p26/amd64
Comment 2 linpct 2015-10-01 16:53:28 UTC 
Maintainer approved.

Since we have clang at FreeBSD 10+, I think we could apply the patch.

Thanks.
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-01 17:41:35 UTC 
testing@work.
Comment 4 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-01 17:42:03 UTC 
*** Bug 203370 has been marked as a duplicate of this bug. ***
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-10-01 17:46:45 UTC 
A commit references this bug:

Author: pi
Date: Thu Oct  1 17:46:25 UTC 2015
New revision: 398375
URL: https://svnweb.freebsd.org/changeset/ports/398375

Log:
  www/node: fix build on 9.3

  - enforce dependency on gcc48 on 9.3

  PR:		203307
  Submitted by:	fcharlier@ploup.net
  Approved by:	linpct@gmail.com (maintainer)

Changes:
  head/www/node/Makefile
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-01 17:47:00 UTC 
Committed, thanks!
Comment 7 linpct 2015-10-01 17:48:04 UTC 
Thanks for helping.