Bug 203637 - [MAINTAINER] print/epson-inkjet-printer-escpr: Update to 1.6.0
Summary: [MAINTAINER] print/epson-inkjet-printer-escpr: Update to 1.6.0
Status: Closed DUPLICATE of bug 204250
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hiroki Sato
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-10-08 10:56 UTC by Tatsuki Makino
Modified: 2015-11-12 03:24 UTC (History)
2 users (show)

See Also:


Attachments
patch for print/epson-inkjet-printer-escpr (6.71 KB, patch)
2015-10-08 10:56 UTC, Tatsuki Makino
no flags Details | Diff
test log (86.62 KB, text/plain)
2015-10-08 10:56 UTC, Tatsuki Makino
no flags Details
patch for print/epson-inkjet-printer-escpr (7.64 KB, patch)
2015-10-08 23:20 UTC, Tatsuki Makino
koobs: maintainer-approval+
Details | Diff
test log (86.62 KB, text/plain)
2015-10-08 23:23 UTC, Tatsuki Makino
no flags Details
patch for print/epson-inkjet-printer-escpr that fixed a problem of architecture using 64 bits pointer (2.08 KB, patch)
2015-10-26 06:11 UTC, Tatsuki Makino
no flags Details | Diff
test log (87.73 KB, text/plain)
2015-10-26 06:12 UTC, Tatsuki Makino
no flags Details
the "port" with the pkg-plist and all patches (5.21 KB, application/octet-stream)
2015-10-31 14:39 UTC, lenzi.sergio
lenzi.sergio: maintainer-approval+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tatsuki Makino 2015-10-08 10:56:14 UTC
Created attachment 161824 [details]
patch for print/epson-inkjet-printer-escpr

Update to epson-inkjet-printer-escpr-1.6.0.

make makepatch has been run for suppress warnings of portlint.

To Mr. Sato
I want to continue to rent space of FreeBSD project's public FTP server for distfile.
Would you download epson-inkjet-printer-escpr-1.6.0-1lsb3.2.tar.gz and upload it to public FTP?
Comment 1 Tatsuki Makino 2015-10-08 10:56:52 UTC
Created attachment 161825 [details]
test log
Comment 2 Tatsuki Makino 2015-10-08 23:20:46 UTC
Created attachment 161836 [details]
patch for print/epson-inkjet-printer-escpr

attachment 161824 [details] fails to install if ${PREFIX}/share/ppd exists (it was made by print/cups-filters).
Would you use new one?
Comment 3 Tatsuki Makino 2015-10-08 23:23:28 UTC
Created attachment 161837 [details]
test log

test log by attachment 161836 [details] using
Comment 4 Mathieu Arnold freebsd_committer freebsd_triage 2015-10-21 13:45:40 UTC
Where is the distfile coming from ?
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-10-22 03:48:18 UTC
A commit references this bug:

Author: hrs
Date: Thu Oct 22 03:47:24 UTC 2015
New revision: 399947
URL: https://svnweb.freebsd.org/changeset/ports/399947

Log:
  Update to 1.6.0.

  Submitted by:	Tatsuki Makino (maintainer)
  PR:		203637

Changes:
  head/print/epson-inkjet-printer-escpr/Makefile
  head/print/epson-inkjet-printer-escpr/distinfo
  head/print/epson-inkjet-printer-escpr/files/patch-configure.ac
  head/print/epson-inkjet-printer-escpr/files/patch-lib-epson-escpr-api-private.h
  head/print/epson-inkjet-printer-escpr/files/patch-src-Makefile.am
  head/print/epson-inkjet-printer-escpr/files/patch-src-filter.c
  head/print/epson-inkjet-printer-escpr/pkg-plist
Comment 6 Hiroki Sato freebsd_committer freebsd_triage 2015-10-22 03:54:21 UTC
Thanks, committed this update.
Comment 7 lenzi.sergio 2015-10-23 05:11:33 UTC
tested today:2015-10-23  driver version  is 1.6.0 
the driver works, the machine prints the right colors, but HANGS (fails to eject the last page) leaving the power green light blinking
If you power off the printer OR print another JOB, the printer correctly eject the current page, print next pages and HANG in the last printed page (the printer prints the page, but not eject it. Seems that the new drivers is not "closing"  the socket...

Tested scenario:
epson l355 printer in a usb port on computer (1) running cups-2.0.3. 

print a page from another computer(2) using network connection

The system prints the page, hangs at last page. previous version  works as expected
Comment 8 Hiroki Sato freebsd_committer freebsd_triage 2015-10-23 08:25:12 UTC
(In reply to lenzi.sergio from comment #7)

Can you try replacing two patch files in the files/ directory with ones in a tarball which can be obtained from the following URL, and let me know if your symptom persists or not?

 http://people.allbsd.org/~hrs/FreeBSD/escpr-20151023-1.tar.gz
Comment 9 lenzi.sergio 2015-10-23 12:27:20 UTC
I apply the patch, same result the printer hangs at the last page...

it is an epsonl355 that works with 1.4 and 1.5 version of the software


did not work, sorry
Comment 10 Tatsuki Makino 2015-10-25 14:17:37 UTC
The variable "context" in function "XFIFOOpen" in file src/xfifo.c receives pointer 0x803c1b860 from malloc.
But the variable "context" in function "main" in file src/filter.c receives pointer 0x3c1b860 from function XFIFOOpen.
It causes segmentation violation and "kernel: pid 80276 (epson-escpr), uid 193: exited on signal 11 (core dumped)" is recorded in /var/log/messages.
Did 0x800000000 disappear to where?
Comment 11 Tatsuki Makino 2015-10-26 06:11:51 UTC
Created attachment 162455 [details]
patch for print/epson-inkjet-printer-escpr that fixed a problem of architecture using 64 bits pointer

I found 0x800000000. XFIFOOpen is used without a declaration and a definition. So it returns int value instead of void* value.
The fixed patch for src/filter.c will be possible to finish cleanly. My EP-803AW does not cause the same behavior with lenzi's L355 when the fixed patch is used.

And I added cheet sheet for me :)

lenzi.sergio, I'm sorry to bother you.
Would you try it?
Comment 12 Tatsuki Makino 2015-10-26 06:12:31 UTC
Created attachment 162456 [details]
test log
Comment 13 Tatsuki Makino 2015-10-29 10:04:18 UTC
I found 1.6.1 has been released in 2015-10-26.
It is added 3 PPD files only.
Its source code is not changed from 1.6.0.

Where should I report it? Here or creating new one?
Comment 14 lenzi.sergio 2015-10-31 14:39:21 UTC
Created attachment 162641 [details]
the "port"  with the pkg-plist and all patches

Sorry for the delay... business trip... you know....



I applied all the patches and fixed the errors from the pkg-plist that showed after the patch applied  than I pack the port in the tar.gz attachment (must expand in a clean directory) at the same place (/usr/ports/print)

The cups now prints faster and with better quality from the previous version

Very good job..
Comment 15 Tatsuki Makino 2015-11-01 01:45:15 UTC
(In reply to lenzi.sergio from comment #14)

Thank you for taking your precious time for me.

> I applied all the patches and fixed the errors from the pkg-plist that showed after the patch

I'm sorry, your /usr/local/share/ppd/epson-inkjet-printer-escpr/* is garbage of 1.5.2. Could you erase them manually?
The original configure.ac prefers /usr/local/share/ppd instead of a result of `cups-config --datadir` if /usr/local/share/ppd exists. It occurs when print/cups-filters is installed.
I noticed and fixed it in comment #2. After 1.6.0 always use a result of cups-config.

> The cups now prints faster and with better quality from the previous version

Thank you for your feedback.
It seems a fix of attachment 162455 [details] is correct.
And, I have already made 1.6.1 with that fix.
Please wait until 1.6.1 or attachment 162455 [details] is committed.

Thank you very much again.
Comment 16 Tatsuki Makino 2015-11-03 12:10:13 UTC
I reported Bug 204250.
This bug can be closed, maybe.
Comment 17 Hiroki Sato freebsd_committer freebsd_triage 2015-11-12 03:24:47 UTC

*** This bug has been marked as a duplicate of bug 204250 ***