Bug 203836 - [MAINTAINER] ftp/filezilla: update to 3.14.1
Summary: [MAINTAINER] ftp/filezilla: update to 3.14.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jason Unovitch
URL:
Keywords: easy, needs-qa, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-10-17 13:46 UTC by Matthew Rezny
Modified: 2015-10-22 00:55 UTC (History)
1 user (show)

See Also:

Attachments
ftp/filezilla update to 3.14.1 (1.38 KB, patch)
2015-10-17 13:46 UTC, Matthew Rezny 		rezny: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Rezny freebsd_committer freebsd_triage 2015-10-17 13:46:14 UTC 
Created attachment 162150 [details]
ftp/filezilla update to 3.14.1

Update FileZilla to 3.14.1 and pet portlint.
Comment 1 Jason Unovitch freebsd_committer freebsd_triage 2015-10-20 02:51:12 UTC 
Mark PR in progress.  Pending QA builds now on all releases now.  A visual on the patch and portlint look good.
Comment 2 Jason Unovitch freebsd_committer freebsd_triage 2015-10-21 10:26:08 UTC 
One question, why are we removing WX_UNICODE?  Otherwise builds and QA were all fine on the following and this is ready to commit.

10.1-RELEASE-p22     amd64
10.1-RELEASE-p22     i386
10.2-RELEASE-p5      amd64
10.2-RELEASE-p5      i386
11.0-CURRENT r289084 amd64
11.0-CURRENT r289115 i386
Comment 3 Matthew Rezny freebsd_committer freebsd_triage 2015-10-21 12:58:07 UTC 
(In reply to Jason Unovitch from comment #2)

wxWidgets is now always Unicode so WX_UNICODE is deprecated and use of it will now cause this warning and wait on every port make step if you have DEVELOPER=yes

/!\ filezilla-3.14.1: Makefile warnings, please consider fixing /!\

WX_UNICODE is not needed: Now no-op as only unicode is supported now
Comment 4 Jason Unovitch freebsd_committer freebsd_triage 2015-10-22 00:37:31 UTC 
(In reply to matthew from comment #3)
Ooops, thank you very much for the sanity check.  Now I remember seeing it among the stream of commit messages and see it mentioned in https://svnweb.FreeBSD.org/ports?view=revision&revision=397077.
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-10-22 00:47:05 UTC 
A commit references this bug:

Author: junovitch
Date: Thu Oct 22 00:46:19 UTC 2015
New revision: 399940
URL: https://svnweb.freebsd.org/changeset/ports/399940

Log:
  ftp/filezilla: update 3.14.0 -> 3.14.1 plus minor fixes

  - Fix indentation in BROKEN statement
  - Remove WX_UNICODE (no-op after r397077)

  Changes:	https://filezilla-project.org/versions.php

  PR:		203836
  Submitted by:	matthew@reztek.cz (maintainer)

Changes:
  head/ftp/filezilla/Makefile
  head/ftp/filezilla/distinfo
Comment 6 Jason Unovitch freebsd_committer freebsd_triage 2015-10-22 00:55:19 UTC 
Update committed.  Thanks for the good work!  And thanks again for the sanity check on WX_UNICODE.  I remember seeing the commit but it completely slipped my mind and I would rather ask the question and commit something I know to be completely correct.