Bug 203983 - [patch] games/0ad 0.0.18_1 build failure due to invalid number of argument for upnpDiscover function
Summary: [patch] games/0ad 0.0.18_1 build failure due to invalid number of argument fo...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-10-23 13:55 UTC by Thibault Payet
Modified: 2015-10-24 07:12 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (madpilot)

Attachments
Patch to fix it (not the best solution I think) (895 bytes, patch)
2015-10-23 13:55 UTC, Thibault Payet 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Payet 2015-10-23 13:55:05 UTC 
Created attachment 162394 [details]
Patch to fix it (not the best solution I think)

When I attempt to build 0ad from port , I get an error about invalid number of argument in the function upnpDiscover.
So I made a patch to get this compiled.
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2015-10-23 14:04:34 UTC 
Hi, thanks for reporting this.

I'll test your patch, since this is a biggish port, please allow me for time for this.

I'll also try to discover what triggered this, since it was not happening a few weeks ago!

I'll keep you updated.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2015-10-23 14:13:01 UTC 
Hi again,

already found the cause. The net/miniupnp port was updated and it contains an API change.

While your patch isn't wrong I'll import the change from the upstream repository which addresses this same problem:

http://trac.wildfiregames.com/changeset/17091/ps/trunk/source/network/NetServer.cpp
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2015-10-23 14:13:41 UTC 
Comment on attachment 162394 [details]
Patch to fix it (not the best solution I think)

Will use changeset from upstream repository.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-10-24 07:12:21 UTC 
A commit references this bug:

Author: madpilot
Date: Sat Oct 24 07:12:14 UTC 2015
New revision: 400109
URL: https://svnweb.freebsd.org/changeset/ports/400109

Log:
  Import change from upstream to fix build after net/miniupnp update. [1]

  While here also mark BROKEN on 9.x, due to gcc crashing during the
  build.

  PR:		203983 [1]
  Submitted by:	monwarez at mailoo.org

Changes:
  head/games/0ad/Makefile
  head/games/0ad/files/patch-source_network_NetServer.cpp
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2015-10-24 07:12:41 UTC 
Fix committed.

Thanks again for reporting the issue.