Bug 203990 - databases/riak2: incorrect ONLY_FOR_ARCHS
Summary: databases/riak2: incorrect ONLY_FOR_ARCHS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-23 21:43 UTC by Dmitry Marakasov
Modified: 2015-11-12 13:31 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (wg)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-10-23 21:43:34 UTC 
As I've already mentioned in the mail, regarding r399337

> +ONLY_FOR_ARCHS=      amd64
> +ONLY_FOR_ARCHS_REASON=       Does not build on i386

This is incorrect:
- There are other architectures than just i386 and amd64. Either fix the
  message, or change this to NOT_FOR_ARCHS=i386.
- Is it DOCUMENTED as not supporting i386, or does it just not build? In
  latter case, you should use BROKEN_i386 instead
Comment 1 William Grzybowski freebsd_committer freebsd_triage 2015-10-23 22:02:18 UTC 
You have my approval to commit, thank you.
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-10-26 21:13:37 UTC 
There's nothing to commit yet, I've asked for clarification
Comment 3 William Grzybowski freebsd_committer freebsd_triage 2015-10-26 21:25:48 UTC 
What is there to clarify? I have tested, it doesn't build, as simple as that, this is the only platform a have to work on.
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2015-10-29 16:32:47 UTC 
I've already written that in the first message.

I wanted to clarify

- whether it does not build on i386 or it does not build on !amd64. These are completely different things.
- whether it's not supposed to build (as in "it depends on amd64 assembly and there's no way to make it work on i386") or it doesn't build because of a bug which may be fixed later
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2015-11-12 12:51:39 UTC 
Ping
Comment 6 William Grzybowski freebsd_committer freebsd_triage 2015-11-12 12:52:52 UTC 
I dont know how to answer your question, sorry.
Comment 7 Dmitry Marakasov freebsd_committer freebsd_triage 2015-11-12 13:11:13 UTC 
What do you mean you don't know? These are fairly simple questions, as a maintainer you must be able to answer them.
Comment 8 William Grzybowski freebsd_committer freebsd_triage 2015-11-12 13:17:14 UTC 
BUt I am not, I already told you what I knew, if you don't think I am capable to maintain this port you have my blessing to take it.
Comment 9 Dmitry Marakasov freebsd_committer freebsd_triage 2015-11-12 13:30:18 UTC 
Ok, then I'll just turn it into BROKEN_i386.
Comment 10 commit-hook freebsd_committer freebsd_triage 2015-11-12 13:31:10 UTC 
A commit references this bug:

Author: amdmi3
Date: Thu Nov 12 13:30:36 UTC 2015
New revision: 401346
URL: https://svnweb.freebsd.org/changeset/ports/401346

Log:
  - Fix shebangs [1]
  - Change ONLY_FOR_ARCHS to BROKEN [2]

  PR:		203990 [2]
  Approved by:	portmgr blanket [1], maintainer [2]

Changes:
  head/databases/riak2/Makefile