Bug 203991 - sysutils/ipfs-go: incorrect ONLY_FOR_ARCHS
Summary: sysutils/ipfs-go: incorrect ONLY_FOR_ARCHS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: William Grzybowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-23 21:43 UTC by Dmitry Marakasov
Modified: 2015-11-05 13:57 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (wg)

Attachments
32 bit combatibility patch (868 bytes, patch)
2015-10-26 21:37 UTC, Dmitry Marakasov 		no flags Details | Diff
32 bit combatibility patch (1.87 KB, patch)
2015-10-29 16:34 UTC, Dmitry Marakasov 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-10-23 21:43:36 UTC 
As I've already mentioned in the mail, regarding r399338

> +ONLY_FOR_ARCHS=      amd64
> +ONLY_FOR_ARCHS_REASON=       Does not build on i386 due to a dependency

Please remove that. The fact a dependency is marked ONLY_FOR_ARCHS is
more than enough, you shouldn't infect whole consumer tree with it.
Comment 1 William Grzybowski freebsd_committer freebsd_triage 2015-10-23 22:01:28 UTC 
Its a bultin dependency not external. Work as expected.

I am not going to remove that and keep receiving poudriere errors everyday.
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2015-10-26 21:37:05 UTC 
Inconsistency between ONLY_FOR_ARCHS and ONLY_FOR_ARCHS_REASON is still there. Also, there's no clarification which `dependency' is implied here. It seems to not build because of type mismatch, so it should be marked BROKEN instead. Though, of course, it should better be fixed instead. Attached is simple patch which fixes the build. It may need some testing though.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2015-10-26 21:37:28 UTC 
Created attachment 162484 [details]
32 bit combatibility patch
Comment 4 William Grzybowski freebsd_committer freebsd_triage 2015-10-26 21:42:37 UTC 
Attached patch has no files/*, just Makefile change.
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2015-10-29 16:34:12 UTC 
Created attachment 162572 [details]
32 bit combatibility patch

Oops, fixed
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-11-05 13:56:52 UTC 
A commit references this bug:

Author: wg
Date: Thu Nov  5 13:56:20 UTC 2015
New revision: 400853
URL: https://svnweb.freebsd.org/changeset/ports/400853

Log:
  sysutils/ipfs-go: fix build for i386

  PR:		203991
  Submitted by:	amdmi3

Changes:
  head/sysutils/ipfs-go/Makefile
  head/sysutils/ipfs-go/files/extra-patch-32bit