Bug 204054 - www/libevhtp: upgrade to 1.2.10
Summary: www/libevhtp: upgrade to 1.2.10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jason Unovitch
URL:
Keywords:
Depends on: 204106
Blocks:
  Show dependency treegraph
 
Reported: 2015-10-27 11:25 UTC by Edward Tomasz Napierala
Modified: 2015-10-30 02:28 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (Ultima1252)


Attachments
patch (2.26 KB, patch)
2015-10-27 11:25 UTC, Edward Tomasz Napierala
no flags Details | Diff
libevhtp.diff (3.26 KB, patch)
2015-10-29 21:07 UTC, Ultima
Ultima1252: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Edward Tomasz Napierala freebsd_committer freebsd_triage 2015-10-27 11:25:50 UTC
Created attachment 162494 [details]
patch

Attached patch updates the port to 1.2.10.  Not tested with poudriere, though.
Comment 1 Jason Unovitch freebsd_committer freebsd_triage 2015-10-29 03:17:16 UTC
www/libevhtp has a new maintainer as the original maintainer has a new family member to keep their hands full.  Assign to new maintainer for feedback.
Comment 2 Ultima 2015-10-29 16:08:09 UTC
Hello Edward, thanks for submitting a patch. Could you please explain the the change to file evhtp.h, why it needs EVHTP_EXPORT?
Comment 3 Edward Tomasz Napierala freebsd_committer freebsd_triage 2015-10-29 19:25:08 UTC
Without it, the symbol wouldn't get exported.  Basically you would get a link error without it.  Same change was committed to the upstream, see https://github.com/ellzey/libevhtp/commit/c2168be8dff307ebc7aeea47bc79f7a615bd2da5.
Comment 4 Ultima 2015-10-29 21:07:50 UTC
Created attachment 162578 [details]
libevhtp.diff

Patch looks good to me. I'm adding a couple more things to make portlint and poudriere happy with a couple options.

* Update to 1.2.10
* include/onigposix.h to PLIST only when option EVHTP_DISABLE_REGEX not selected
* include/evthr.h only when option EVHTP_DISABLE_EVTHR not selected
* Recreated patch files for portlint

Thanks again Edward =]
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-10-30 02:26:04 UTC
A commit references this bug:

Author: junovitch
Date: Fri Oct 30 02:25:41 UTC 2015
New revision: 400488
URL: https://svnweb.freebsd.org/changeset/ports/400488

Log:
  www/libevhtp: update 1.2.9 -> 1.2.10 and assorted fixes

  - Update PORTVERSION, GH_TAGNAME, and distinfo for 1.2.10
  - include/onigposix.h in PLIST when EVHTP_DISABLE_REGEX is not selected
  - include/evthr.h when option EVHTP_DISABLE_EVTHR is not selected
  - Add patch to ensure symbol gets exported from evhtp.h
  - Recreated patch files for portlint

  PR:		204054
  Submitted by:	trasz (original patch, multiple changes from maintainer)
  Approved by:	Ricky Gallamore <ultima1252@gmail.com> (maintainer)

Changes:
  head/www/libevhtp/Makefile
  head/www/libevhtp/distinfo
  head/www/libevhtp/files/patch-evhtp.c
  head/www/libevhtp/files/patch-evhtp.h
Comment 6 Jason Unovitch freebsd_committer freebsd_triage 2015-10-30 02:28:26 UTC
Committed. Thanks!

Add depends on bug 204106 to have the audit trail on why the maintainer-feedback was fixed.

See also: https://lists.FreeBSD.org/pipermail/freebsd-ports/2015-October/100923.html