Bug 204644 - www/chromium: Cannot open files containing spaces, bad shell script
Summary: www/chromium: Cannot open files containing spaces, bad shell script
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Rene Ladan
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2015-11-17 20:54 UTC by Anthony Eadicicco
Modified: 2016-01-29 09:42 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback+
koobs: merge-quarterly+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Eadicicco 2015-11-17 20:54:01 UTC
The Chromium port ships with a wrapper script at /usr/local/bin/chrome to ensure a sysctl is properly set. This then redirects input to the real binary, but is doing so incorrectly. The offending line:

exec /usr/local/share/chromium/chrome $*

should read:

exec /usr/local/share/chromium/chrome "$@"
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-18 03:10:38 UTC
Thanks for the report Anthony!

Can you attach a log showing the bug with the current script and the bug working with the 'fixed' script.

If you can attach a unified diff against the port head that fixes the issue, that would also help, but is not absolutely required
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-01-29 08:14:02 UTC
A commit references this bug:

Author: rene
Date: Fri Jan 29 08:13:58 UTC 2016
New revision: 407459
URL: https://svnweb.freebsd.org/changeset/ports/407459

Log:
  www/chromium: update to 48.0.2564.97 [1]

  While here, fix startup script [2]
  PR:		204644 [2]
  Submitted by:	Christoph Moench-Tegeder via Github [1]
  Submitted by:	Anthony Eadicicco [2]
  MFH:		2016Q1

Changes:
  head/www/chromium/Makefile
  head/www/chromium/distinfo
  head/www/chromium/files/chrome.in
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-01-29 09:03:07 UTC
A commit references this bug:

Author: rene
Date: Fri Jan 29 09:02:57 UTC 2016
New revision: 407460
URL: https://svnweb.freebsd.org/changeset/ports/407460

Log:
  MFH: r407459

  www/chromium: update to 48.0.2564.97 [1]

  While here, fix startup script [2]
  PR:		204644 [2]
  Submitted by:	Christoph Moench-Tegeder via Github [1]
  Submitted by:	Anthony Eadicicco [2]
  Approved by:	portmgr (erwin)

Changes:
_U  branches/2016Q1/
  branches/2016Q1/www/chromium/Makefile
  branches/2016Q1/www/chromium/distinfo
  branches/2016Q1/www/chromium/files/chrome.in
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2016-01-29 09:42:40 UTC
Assign to committer that resolved, and set merge-quarterly done (+)

@Rene Please do the same for future issues :)