Bug 204816 - audio/audacity: Produces corrupt PNG files
Summary: audio/audacity: Produces corrupt PNG files
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Thomas Zander
URL:
Keywords: easy, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-11-25 20:20 UTC by lenzi.sergio
Modified: 2015-12-13 12:13 UTC (History)
3 users (show)

See Also:
riggs: merge-quarterly-

Attachments
Patch to only dos2unix text files (440 bytes, patch)
2015-11-27 10:46 UTC, Jack 		xxjack12xx: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description lenzi.sergio 2015-11-25 20:20:35 UTC 
ports audio/audacity produces corrupt png images.

This is because the port, uses dos2unix framework, and incorrectly convert dos2tounix on ALL files in the WRKSRC files, including ...  png images

an option on the Makefile, would fix the problem...

DOS2UNIX_GLOB=  Makefile.* *.c *.h
Comment 1 Jack 2015-11-25 22:27:01 UTC 
Should use the options
DOS2UNIX_GLOB=  Makefile.* *.c* *.h

to cover .cpp files too
Comment 2 lenzi.sergio 2015-11-26 18:05:17 UTC 
(In reply to xxjack12xx from comment #1)
correct....
Thanks, should bug the mantainer now..
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-27 03:18:12 UTC 
@Jack can you attach a patch to address the issue please?

This also needs to be MFH'd if relevant to the quarterly branch version.
Comment 4 Jack 2015-11-27 10:12:19 UTC 
Sure, will have a patch ready shortly.
Comment 5 Jack 2015-11-27 10:46:22 UTC 
Created attachment 163576 [details]
Patch to only dos2unix text files
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-27 10:58:56 UTC 
@Lenzi, can you test the attached patch and confirm whether that resolves the issue for you. Thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-12-13 12:12:10 UTC 
A commit references this bug:

Author: riggs
Date: Sun Dec 13 12:11:48 UTC 2015
New revision: 403661
URL: https://svnweb.freebsd.org/changeset/ports/403661

Log:
  Fix accidental dos2unix on non-text-files during build

  PR:		204816
  Submitted by:	lenzi.sergio@gmail.com
  Approved by:	xxjack12xx@gmail.com (maintainer)

Changes:
  head/audio/audacity/Makefile
Comment 8 Thomas Zander freebsd_committer freebsd_triage 2015-12-13 12:13:31 UTC 
No MFH, this only affects HEAD.