Bug 204973 - graphics/hugin: cleanup, make python optional, sort plist
Summary: graphics/hugin: cleanup, make python optional, sort plist
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Greg Lehey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-02 18:16 UTC by Dmitry Marakasov
Modified: 2016-01-30 03:40 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (grog)


Attachments
Patch (13.08 KB, patch)
2015-12-02 18:16 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-12-02 18:16:57 UTC
Created attachment 163780 [details]
Patch

- Remove unused depends (lensfun, tclap)
- Cleanup unneeded cmake patching
- Specify proper compiler requirement
- Make python optional
- Modernize options handling
- Sort plist
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-01-28 01:59:41 UTC
A commit references this bug:

Author: grog
Date: Thu Jan 28 01:58:51 UTC 2016
New revision: 407392
URL: https://svnweb.freebsd.org/changeset/ports/407392

Log:
  Tidy up:
  - Remove unused dependencies on lensfun and tclap.
  - Clean up unneeded cmake patching.
  - Relax compiler restrictions.
  - Make python optional.
  - Modernize options handling.
  - Sort plist.

  This is basically what was submitted in PR 204973.  It's not clear
  whether it's a good idea to make python optional, but Hugin works
  without it.

  PR:		204973
  Submitted by:	Dmitry Marakasov
  Approved by:	edwin (mentor)
  MFC after:	2 weeks

Changes:
  head/graphics/hugin/Makefile
  head/graphics/hugin/pkg-plist
Comment 2 Greg Lehey freebsd_committer freebsd_triage 2016-01-28 02:02:43 UTC
Thanks for the patch.  I've committed it essentially as submitted.  Only the enblend version is very sensitive, so I've left that unchanged.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2016-01-30 03:40:22 UTC
(In reply to Greg Lehey from comment #2)
> Thanks for the patch.  I've committed it essentially as submitted.

Thank you!

> Only the enblend version is very sensitive, so I've left that unchanged.

There's no enblend < 3.1.r20080615 in ports, so this makes no sense.