Bug 205218 - [PATCH] science/mol2ps: Update to version 0.4b
Summary: [PATCH] science/mol2ps: Update to version 0.4b
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-12-10 18:40 UTC by tkato432
Modified: 2015-12-28 14:19 UTC (History)
3 users (show)

See Also:
miwi: maintainer-feedback? (tkato432)

Attachments
science_mol2ps.diff (1.18 KB, patch)
2015-12-10 18:40 UTC, tkato432 		no flags Details | Diff
science_mol2ps.diff (1.99 KB, patch)
2015-12-18 12:30 UTC, tkato432 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tkato432 2015-12-10 18:40:47 UTC 
Created attachment 164074 [details]
science_mol2ps.diff
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2015-12-18 08:48:56 UTC 
http://pkgdev.miwibox.org/data/93i386-miwi/2015-12-18_08h00m17s/logs/errors/mol2ps-0.4b.log

build fails on all archs. Can you please check.
Comment 2 tkato432 2015-12-18 12:30:26 UTC 
Created attachment 164348 [details]
science_mol2ps.diff

It seems there is some incompatibility between the latest freepascal
compiler and previous version.
Comment 3 John Marino freebsd_committer freebsd_triage 2015-12-21 11:21:20 UTC 
I'll take it; I've fixed others like this.
Comment 4 Martin Wilke freebsd_committer freebsd_triage 2015-12-21 11:35:57 UTC 
better you ask before you taking other prs. thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-12-21 11:41:00 UTC 
A commit references this bug:

Author: marino
Date: Mon Dec 21 11:40:00 UTC 2015
New revision: 404090
URL: https://svnweb.freebsd.org/changeset/ports/404090

Log:
  science/mol2ps: Upgrade version 0.4a => 0.4b and unbreak

  PR patch had to be modified after FPC was updated to 3.0.0

  PR:		205218
  Submitted by:	Ports Fury

Changes:
  head/science/mol2ps/Makefile
  head/science/mol2ps/distinfo
Comment 6 John Marino freebsd_committer freebsd_triage 2015-12-21 11:43:08 UTC 
1) I didn't realize until now that a replacement patch had been provided
2) the replacement patch was wrong.  Removing a unit declaration is not the solution.

There's lots more PRs, plenty to go around.
Comment 7 Martin Wilke freebsd_committer freebsd_triage 2015-12-21 11:45:26 UTC 
That does not change the fact that you just took a pr which not belongs to you, as long its not timeout! So please respect that in the first place!
Comment 8 John Marino freebsd_committer freebsd_triage 2015-12-21 11:47:41 UTC 
Conclusion: Asking is more important than correctness.

This is way to trivial to get upset about.  I'm sorry that I prevented you from making a bad commit.  I'll let you do that next time.