Created attachment 164203 [details] SVN diff for upgrading audio/beets from 1.3.11 to 1.3.15 See the changelog [1]. - New options BADFILES, IPFS, METASYNC_DBUS Dependency changes: - Increase the minimum version of devel/py-enum34 - declared in setup.py [2] - New required dependency devel/py-jellyfish - Upstream changed the optional dependency from audio/py-mpd to audio/py-mpd2 - New optional dependencies audio/flac, audio/mp3val, sysutils/ipfs-go, devel/py-dbus - Remove an unneeded dependency to audio/py-mpd from The BPD plugin - Correct the package name prefix for beautifulsoup [1] http://beets.readthedocs.org/en/v1.3.15/changelog.html [2] https://github.com/sampsyo/beets/blob/v1.3.15/setup.py
Hi, Looking at: .if ! ${PORT_OPTIONS:MX11} IMAGEMAGICK_RUN_DEPENDS= convert:${PORTSDIR}/graphics/ImageMagick-nox11 .endif there is no option for it, also can we convert it to the new options helper :)? Thanks in advance.
The option MX11 is a test for "OPTIONS_UNSET=X11" in '/etc/make.conf'. Lots of other ports use it as well: grep -R --include=*/Makefile MX11 /usr/ports What is the new options helper?
Hi Sorry to say it makes no sense. do this run make config disable all options: run make all-depends-list safe the output, redo make config and enable Imagemagick only run make all-depends-list and look what it shows; it use graphics/ImageMagick-nox11 instant of graphics/ImageMagick my /etc/make.conf have no UNSET flags set. Soon as I have set all options except Imagemagik and run all-depends-list again it still links to x11 releated ports because your dependency don't have nox11 related knobs. .if ! ${PORT_OPTIONS:MX11} IMAGEMAGICK_RUN_DEPENDS= convert:${PORTSDIR}/graphics/ImageMagick-nox11 .endif should be removed because it does not what it is suppose to be.
Thanks for clarifying, I have reproduced the situation that you describe. The current approach of selecting the -nox11 variant of ImageMagick is broken. What do you recommend between: * removing the 'MX11' check and let the IMAGEMAGICK option install the convert command from graphics/ImageMagick * defining a new option X11 in audio/beets similar to how www/piwigo does it?
As i have said MX11 knob should be removed.
Created attachment 164325 [details] SVN diff for upgrading audio/beets from 1.3.11 to 1.3.15 without -nox11 Here is a new patch which also removes the -nox11 variant selection of the ImageMagick dependency.
A commit references this bug: Author: miwi Date: Mon Dec 21 15:18:20 UTC 2015 New revision: 404116 URL: https://svnweb.freebsd.org/changeset/ports/404116 Log: - Update to 1.3.15 - Remove unused X11 options PR: 205297 Submitted by: maintainer Approved by: mat (mentor) Differential Revision: D4569 Changes: head/audio/beets/Makefile head/audio/beets/distinfo