Bug 205442 - [PATCH] deskutils/py-spice-gtk: Fix plist and unmark BROKEN.
Summary: [PATCH] deskutils/py-spice-gtk: Fix plist and unmark BROKEN.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Raphael Kubo da Costa
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-12-19 22:31 UTC by Raphael Kubo da Costa
Modified: 2016-01-02 23:10 UTC (History)
2 users (show)

See Also:
rakuco: maintainer-feedback-

Attachments
Proposed patch (1.09 KB, patch)
2015-12-19 22:31 UTC, Raphael Kubo da Costa 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-19 22:31:38 UTC 
Created attachment 164396 [details]
Proposed patch

The attached patch removes the static library version of SpiceClientGtk.a from the port's plist. After 0.26, the spice-gtk disables static builds by default. I tried passing --enable-static, but the build fails:

gmake[3]: Entering directory '/wrkdirs/usr/ports/deskutils/py-spice-gtk/work/spice-gtk-0.30/tests'
  CC       coroutine.o
  CC       util.o
  CC       session.o
  CCLD     coroutine
  CCLD     session
  CCLD     util
/usr/bin/ld: undefined reference to symbol `hypot@@FBSD_1.0' (try adding -lm)
//lib/libm.so.5: could not read symbols: Bad value
cc: error: linker command failed with exit code 1 (use -v to see invocation)
Makefile:719: recipe for target 'session' failed
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2015-12-20 07:30:50 UTC 
Submitter is Committer.
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-20 19:05:06 UTC 
Resetting to the original title, we usually keep [PATCH] in the titles AFAIK.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-01-02 23:09:44 UTC 
A commit references this bug:

Author: rakuco
Date: Sat Jan  2 23:09:37 UTC 2016
New revision: 405100
URL: https://svnweb.freebsd.org/changeset/ports/405100

Log:
  py-spice-gtk: Fix plist and unmark BROKEN.

  The attached patch removes the static library version of SpiceClientGtk.a from
  the port's plist. After 0.26, the spice-gtk disables static builds by default.
  I tried passing --enable-static, but the build fails:

  gmake[3]: Entering directory '/wrkdirs/usr/ports/deskutils/py-spice-gtk/work/spice-gtk-0.30/tests'
    CC       coroutine.o
    CC       util.o
    CC       session.o
    CCLD     coroutine
    CCLD     session
    CCLD     util
  /usr/bin/ld: undefined reference to symbol `hypot@@FBSD_1.0' (try adding -lm)
  //lib/libm.so.5: could not read symbols: Bad value
  cc: error: linker command failed with exit code 1 (use -v to see invocation)
  Makefile:719: recipe for target 'session' failed

  PR:		205442
  Approved by:	maintainer timeout (15 days)

Changes:
  head/deskutils/py-spice-gtk/Makefile
  head/deskutils/spice-gtk/Makefile