Bug 205484 - audio/audacity: Add an OPTION for FFmpeg support
Summary: audio/audacity: Add an OPTION for FFmpeg support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: easy, feature, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-12-21 09:53 UTC by Tatsuki Makino
Modified: 2015-12-25 21:42 UTC (History)
2 users (show)

See Also:
xxjack12xx: maintainer-feedback+


Attachments
hint to add the FFMPEG option (1.57 KB, patch)
2015-12-21 09:53 UTC, Tatsuki Makino
vlad-fbsd: maintainer-approval+
Details | Diff
test log (attachment 164449 applied and option FFMPEG set) (72.71 KB, application/x-xz)
2015-12-22 23:24 UTC, Tatsuki Makino
no flags Details
test log (attachment 164449 applied and option FFMPEG unset) (71.68 KB, application/x-xz)
2015-12-22 23:26 UTC, Tatsuki Makino
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tatsuki Makino 2015-12-21 09:53:53 UTC
Created attachment 164449 [details]
hint to add the FFMPEG option

I changed audio/audacity/Makefile.
And I have checked below.
It could build audacity.
The audacity could load libavformat and libavcodec. Those libraries were appeared in preferences dialog.
The audacity could import m4a file.
The audacity could export mpeg format + mp2 codec file.
Comment 1 Jack 2015-12-21 19:57:39 UTC
I'll check and see if this works properly.
Comment 2 Jack 2015-12-22 20:01:24 UTC
The patch added ffmpeg support properly for me.
Comment 3 Tatsuki Makino 2015-12-22 23:24:39 UTC
Created attachment 164516 [details]
test log (attachment 164449 [details] applied and option FFMPEG set)
Comment 4 Tatsuki Makino 2015-12-22 23:26:26 UTC
Created attachment 164518 [details]
test log (attachment 164449 [details] applied and option FFMPEG unset)
Comment 5 VK freebsd_triage 2015-12-24 00:40:34 UTC
Comment on attachment 164449 [details]
hint to add the FFMPEG option

xxjack12xx,

I am assuming you're approving the patch. Note that you have the ability to approve patches for ports you're maintainer of.
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-12-25 12:12:53 UTC
A commit references this bug:

Author: riggs
Date: Fri Dec 25 12:12:25 UTC 2015
New revision: 404414
URL: https://svnweb.freebsd.org/changeset/ports/404414

Log:
  Add support for ffmpeg and add non-default OPTION

  PR:		205484
  Submitted by:	tatsuki_makino@hotmail.com
  Approved by:	xxjack12xx@gmail.com (maintainer)

Changes:
  head/audio/audacity/Makefile
Comment 7 Thomas Zander freebsd_committer freebsd_triage 2015-12-25 12:17:15 UTC
Committed with minor simplifications:
- There is a default description for ffmpeg which is fine for the use case in this port
- Although audacity uses several shlibs from ffmpeg, it is sufficient to add a dependency to one of them in Makefile
Comment 8 Tatsuki Makino 2015-12-25 21:42:31 UTC
Thank you very much.