here a links to get distfile for megaglest source 3.9.0.4 https://drive.google.com/file/d/0BxPSydeboyzDNThoeVNLLTVZaTQ/view?usp=sharing I don't know if it could be fetch able on GitHub
Thank you for your submission. FreeBSD Ports can indeed obtain distribution files via github with: USE_GITHUB=yes For more information, see: http://www2.au.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-master_sites-github-description CC'ing committer that marked BROKEN
Actually removing MASTER_SITES=SF/... and BROKEN=... , fix the port and download from distcache.FreeBSD.org
distcache is not supposed to be a source, it is there as a fallback in case of outage on upstreams. The ports needs a proper upstream (and no issue with using github)
Created attachment 164451 [details] Makefile
Created attachment 164452 [details] The distinfo
Created attachment 164453 [details] The diff of Makefile
Nice work :) Some tips: * You can provide a single (unified) diff for both files (Makefile/distinfo), using svn diff or diff -u in the port directory. * GH_TAGNAME defaults to PORTVERSION, so that line shouldn't be necessary * WRKSRC overriding shouldn't be necessary with USE_GITHUB=yes * The official upstream Github account/repository should be used: https://github.com/MegaGlest/megaglest-source Note: they don't seem to have a tag for 3.9.0.4 yet. Create an issue on github for them to create one
Current version of MegaGlest is 3.11.1. Shouldn't we upgrade to that version instead of trying to make 3.9.0.4 work? Rusty
It could be a great idea, we need some patch I think (in the past I never get to build 3.11.1). Maybe check the dependency too I post an issue on Github , it appears that the version 3.9.0.4 was produced on request of a Gentoo developer/packager. https://github.com/MegaGlest/megaglest-source/issues/96#issuecomment-166306055
Created attachment 164599 [details] svn diff of the port I succed to build the port but failed in the generating temporary packaging list megaglest-source-3.11.1/glest.ini No such file or directory
Created attachment 164600 [details] Is the final diff to get it build entirely With this diff you can build 3.11.1
Created attachment 164601 [details] the shar file of the port
Created attachment 164625 [details] megaglest.shar I forget to remove PORTREVISION
Created attachment 164662 [details] megaglest.shar Add me to maintainer
@monwarez, can you confirm this passes QA (portlint, poudriere) please?
Comment on attachment 164662 [details] megaglest.shar Post is unmaintained, implicit approval
It's not passed yet , I have placed USE_GITHUB ... in the wrong section
Created attachment 164669 [details] megaglest.shar Pass the portlint test
Created attachment 164696 [details] megaglest.shar Pass the poudriere testport
Created attachment 164699 [details] megaglest diff here is the svn diff, It pass QA (portlint , poudriere) test
Created attachment 164759 [details] megaglest diff I forget to do svn rm to an old patch
Does not patch: ===> Applying FreeBSD patches for megaglest-3.11.1 2 out of 2 hunks failed--saving rejects to source/shared_lib/sources/miniz/miniz.c.rej => Patch patch-source_shared__lib_sources_miniz_miniz.c failed to apply cleanly. => Patch(es) patch-source-shared_lib-sources-platform-posix-ircclient.cpp patch-source__shared_lib__CMakeLists.txt applied cleanly.
normally I remove this patch in the diff
Nevermind the diff is not the correct one
Created attachment 164824 [details] megaglest diff It should be good now , I deleted the wrong patch
We have to do manually: svn remove files/patch-source_shared__lib_sources_miniz_miniz.c
In the files directory they should have only this : megaglest/files/patch-source__shared_lib__CMakeLists.txt megaglest/files/patch-source-shared_lib-sources-platform-posix-ircclient.cpp megaglest/files/pkg-message.in megaglest/files/patch-source_shared__lib_sources_platform_posix_socket.cpp
Normally with svn diff it should be build
Now good. Will test and commit it along with 205581
Created attachment 168653 [details] megaglest-3.12.0 svn diff Notice: The patch was done with megaglest-3.9.0.4_8 base. I will post a poudriere testport log when I finished to build in poudriere
Created attachment 168665 [details] megaglest-3.12.0 svn diff I am sorry, I forget to change the SDL version, now MegaGlest use SDL2
Created attachment 168666 [details] megaglest testport log
For the moment the game will not launch because apparently Megaglest need to have force feedback (HAPTIC) which is not working. I really doubt that Megaglest really need the HAPTIC support.
Sorry for delay - I've jsut committed 3.11.1 patch, please resubmit the update against it.
A commit references this bug: Author: amdmi3 Date: Sun Mar 27 01:10:18 UTC 2016 New revision: 411969 URL: https://svnweb.freebsd.org/changeset/ports/411969 Log: - Update to 3.11.1 - Cleanup the port - Pass maintainership to submitter PR: 205485 Submitted by: monwarez@mailoo.org Changes: head/games/megaglest/Makefile head/games/megaglest/distinfo head/games/megaglest/files/patch-source_shared__lib_sources_miniz_miniz.c head/games/megaglest/pkg-plist
Created attachment 168681 [details] megaglest.diff updated This is update diff, I add an extra patch to disable HAPTIC support in Megaglest(since SDL2 does not support it on FreeBSD). Poudriere testport will come ASAP.
Created attachment 168704 [details] the poudriere testport log
- The patch may be simplified, just calling SDL_Init(SDL_INIT_AUDIO|SDL_INIT_VIDEO|...) - Removing the desktop file and icons is a pessimization. What's the reason for it? Though icon should be installed to ${PREFIX}/share/pixmaps instead.
(In reply to Dmitry Marakasov from comment #38) Yes you right , I don't know why I separated the calling of SDL_Init. For the desktop file , apparently they need to be generated. I will change the patch
For the desktop file, they are in megaglest-data, for now I think I will just install the 3 of them (megaglest.desktop, megaglest_editor.desktop, and megaglest_g3dviewer.desktop). I don't know if it is possible to have OPTIONS synchronized with 2 ports.
Created attachment 168890 [details] megaglest diff So I changed the patch, re-adding ico, and adding g3dviewer option. Testport log will come ASAP.
Created attachment 168892 [details] megaglest diff
Created attachment 168893 [details] megaglest diff
Created attachment 168901 [details] megaglest diff
Created attachment 168918 [details] megaglest diff Now it should work
Created attachment 168919 [details] megaglest poudriere testport log
Note that you don't neet to STRIP binaries as they are already stripped by INSTALL_PROGRAM.
A commit references this bug: Author: amdmi3 Date: Sat Apr 23 00:19:27 UTC 2016 New revision: 413798 URL: https://svnweb.freebsd.org/changeset/ports/413798 Log: - Update to 3.12.0 - While here, convert to options helpers PR: 205485 Submitted by: monwarez@mailoo.org (maintainer) Changes: head/games/megaglest/Makefile head/games/megaglest/distinfo head/games/megaglest/files/patch-source-shared_lib-sources-platform-posix-ircclient.cpp head/games/megaglest/files/patch-source__shared_lib__CMakeLists.txt head/games/megaglest/files/patch-source_shared__lib_include_platform_sdl_platform__main.h head/games/megaglest/files/patch-source_shared__lib_sources_platform_common_platform__common.cpp head/games/megaglest/files/patch-source_shared__lib_sources_platform_posix_socket.cpp head/games/megaglest/pkg-plist