Bug 206158 - [NEW PORT] hamradio/multimon-ng: Digital transmission decoder
Summary: [NEW PORT] hamradio/multimon-ng: Digital transmission decoder
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Diane Bruce
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2016-01-12 15:49 UTC by Fabrice Aneche
Modified: 2017-03-15 13:15 UTC (History)
3 users (show)

See Also:


Attachments
multimon-ng port (1.88 KB, text/plain)
2016-01-12 15:49 UTC, Fabrice Aneche
no flags Details
poudriere log (33.97 KB, text/plain)
2016-01-12 15:50 UTC, Fabrice Aneche
no flags Details
multimon-ng port (1.87 KB, text/plain)
2016-01-15 18:35 UTC, Fabrice Aneche
no flags Details
poudriere log (33.70 KB, text/plain)
2016-01-15 18:37 UTC, Fabrice Aneche
no flags Details
Revised version of multimon-ng port (2.96 KB, text/plain)
2017-03-14 15:48 UTC, Kyle Evans
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fabrice Aneche 2016-01-12 15:49:16 UTC
Created attachment 165437 [details]
multimon-ng port

multimon-ng a fork of multimon. 
It decodes digital transmission modes.

As an example it can be used with rtl_sdr to decode radio amateurs packets: 
rtl_fm -f 144.390M -s 22050  |  multimon-ng -v 10 -t raw -A -
Comment 1 Fabrice Aneche 2016-01-12 15:50:17 UTC
Created attachment 165438 [details]
poudriere log
Comment 2 Diane Bruce freebsd_committer freebsd_triage 2016-01-15 17:50:17 UTC
Script started on Fri Jan 15 12:44:59 2016
% portlint -C
FATAL: Makefile: [3]: use a tab (not space) after a variable name
FATAL: Makefile: [5]: use a tab (not space) after a variable name
FATAL: Makefile: [7]: use a tab (not space) after a variable name
FATAL: Makefile: [10]: use a tab (not space) after a variable name
FATAL: Makefile: [13]: use a tab (not space) after a variable name
5 fatal errors and 0 warnings found.

Script done on Fri Jan 15 12:45:07 2016

Letting new Maintainer fix.
Comment 3 Fabrice Aneche 2016-01-15 18:35:58 UTC
Created attachment 165639 [details]
multimon-ng port

reformatted Makefile passes portlint -C
Comment 4 Fabrice Aneche 2016-01-15 18:37:08 UTC
Created attachment 165640 [details]
poudriere log

poudriere after Makefile reformat
Comment 5 Diane Bruce freebsd_committer freebsd_triage 2016-01-20 16:29:42 UTC
Port should specifically enable or disable pulseaudio as needed.                
It also will fail to link if pulseaudio libs available as you have a missing -L 
                                                                                
If you have a pulseaudio it will fail to build due to this.                     
                                                                                
in the CMakeLists.txt                                                           
elseif( UNIX )                                                                  
        find_package( X11 )                                                     
        if ( X11_FOUND )                                                        
                option( X11_SUPPORT "Enable X11 display support" ${X11_FOUND} ) 
                mark_as_advanced( X11_SUPPORT )                                 
        endif( X11_FOUND )                                                      
        find_package( PulseAudio )                                              
        if ( PULSEAUDIO_FOUND )                                                 
                option( PULSE_AUDIO_SUPPORT "Enable pulse audio support" ${PULSE
AUDIO_FOUND} )                                                                  
                mark_as_advanced( PULSE_AUDIO_SUPPORT )                         
        endif( PULSEAUDIO_FOUND )          

===>  Building for multimon-ng-1.1.0                                            
[  2%] Linking C executable multimon-ng                                         
/usr/bin/ld: cannot find -lpulse-simple         

Back to submitter to fix.
Comment 6 Kyle Evans freebsd_committer freebsd_triage 2017-03-14 15:48:09 UTC
Created attachment 180819 [details]
Revised version of multimon-ng port

Hi,

I'd like this to happen, so I've taken the liberty of working on this a bit. =) Attached is a revised version of this port, with the following changes:

Set MAINTAINER= bsdports@kyle-evans.net -- I assume after a year and change of no communication that this is the safe option

Set LICENSE_FILE=

Defined PULSEAUDIO and X11 options, since these can both be toggled. I also added a patch to fix PULSEAUDIO compilation, since upstream was assuming the compiler path. This patch has been accepted upstream. I have left both options off by default since this is my use case, but I'm open to other recommendations.

I documented the dependency on various xorg bits needed if X11 is enabled, based on complaint from `make package` and observing that they are actually linked into the final binary.

I removed the post-install target, so that ${INSTALL_PROGRAM} can strip the binary as is intended.

Looked over with: portlint -aACN
Test build with: dirty -HEAD system to make sure that pulseaudio/X11 can be detected but still turned off
Test build with: poudriere testport (default OPTIONS)

I'm still waiting on a `poudriere testport` run to complete with both OPTIONS turned on, but I don't foresee any problems given the behavior observed when building on a dirty system and the testport with default OPTIONS was happy. Logs available upon request.
Comment 7 Diane Bruce freebsd_committer freebsd_triage 2017-03-14 19:10:27 UTC
eeek! yes you are right! hey Fabrice this ok?
Comment 8 Fabrice Aneche 2017-03-14 22:08:38 UTC
Hey Diane,

Nice work Kyle, this is perfect !
Comment 9 Diane Bruce freebsd_committer freebsd_triage 2017-03-15 12:44:39 UTC
(In reply to Fabrice Aneche from comment #8)
Yes! Sorry I completely forgot about this PR. So you are ok with Kyle taking maintainership? I'll commit this today in that case.
Comment 10 Fabrice Aneche 2017-03-15 12:45:47 UTC
100% agree
Comment 11 commit-hook freebsd_committer freebsd_triage 2017-03-15 13:13:52 UTC
A commit references this bug:

Author: db
Date: Wed Mar 15 13:13:10 UTC 2017
New revision: 436241
URL: https://svnweb.freebsd.org/changeset/ports/436241

Log:
  multimon-ng a fork of multimon.
  It decodes the following digital transmission modes:

  POCSAG512 POCSAG1200 POCSAG2400
  FLEX
  EAS
  UFSK1200 CLIPFSK AFSK1200 AFSK2400 AFSK2400_2 AFSK2400_3
  HAPN4800
  FSK9600
  DTMF
  ZVEI1 ZVEI2 ZVEI3 DZVEI PZVEI
  EEA EIA CCIR
  MORSE CW

  As an example it can be used with rtl_sdr to decode radio amateurs packets:
  rtl_fm -f 144.390M -s 22050  |  multimon-ng -v 10 -t raw -A -

  WWW: https://github.com/EliasOenal/multimon-ng/

  PR:		206158
  Submitted by:	bsdports@kyle-evans.net

Changes:
  head/comms/Makefile
  head/comms/multimon-ng/
  head/comms/multimon-ng/Makefile
  head/comms/multimon-ng/distinfo
  head/comms/multimon-ng/files/
  head/comms/multimon-ng/files/patch-CMakeLists.txt
  head/comms/multimon-ng/pkg-descr
Comment 12 Diane Bruce freebsd_committer freebsd_triage 2017-03-15 13:15:13 UTC
Thanks guys!