Bug 206405 - net-mgmt/guifi-snpservices Update to 0.2.2.8
Summary: net-mgmt/guifi-snpservices Update to 0.2.2.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Felder
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-19 15:50 UTC by Jochen Neumeister
Modified: 2016-03-20 18:41 UTC (History)
3 users (show)

See Also:
tphilipp: maintainer-feedback+
tphilipp: maintainer-feedback+


Attachments
guifi-snpservices.diff (2.54 KB, patch)
2016-01-19 15:50 UTC, Jochen Neumeister
joneum: maintainer-approval-
Details | Diff
New guifi-snpservices.diff (2.54 KB, patch)
2016-01-22 21:43 UTC, Jochen Neumeister
no flags Details | Diff
complete patch 1 (7.40 KB, patch)
2016-01-31 18:48 UTC, Tassilo Philipp
tphilipp: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Tassilo Philipp 2016-01-22 11:46:22 UTC
Hi,

thanks for the patch and the upgrade to 0.2.2.8. Unfortunately, I don't have a possibility to runtime test this right now, but from just building it, patch-common-refresh_mrtg.php doesn't apply anymore, b/c the source file (common/refresh_mrtg.php) is gone in 0.2.2.8.
As you seem to use the port at the moment, would you mind checking this and fixing the build?
I'll probably get around testing it in a week or two.

btw... awesome that I'm not the only guifi guy on freebsd :)

Thanks
Comment 2 Jochen Neumeister freebsd_committer freebsd_triage 2016-01-22 21:43:38 UTC
Created attachment 165979 [details]
New guifi-snpservices.diff
Comment 4 Tassilo Philipp 2016-01-23 09:45:18 UTC
Thanks, but the new patch is the same as the old one. Are you sure you are running diff with -N?
Comment 5 Tassilo Philipp 2016-01-31 18:48:26 UTC
Created attachment 166363 [details]
complete patch 1

I went ahead and created a patch that also includes the necessary changes to the port's files/*. Find it attached.
Please give the port with this patch applied some thorough testing, as I haven't had a chance to do that, yet. Especially the new 'blacklist.csv' that snpservices 0.2.2-8 seems to introduce isn't tested by me.
Thanks
Comment 6 Tassilo Philipp 2016-02-26 00:17:29 UTC
Ok, not sure what happened to Jochen, he went silent.
Anyways, I finally got around to test this thoroughly, and this is good to go. 

Please commit ("complete patch 1" approved).
Thanks
Comment 7 Tassilo Philipp 2016-03-17 11:30:09 UTC
Please submit
Comment 8 commit-hook freebsd_committer freebsd_triage 2016-03-20 18:40:46 UTC
A commit references this bug:

Author: feld
Date: Sun Mar 20 18:39:55 UTC 2016
New revision: 411512
URL: https://svnweb.freebsd.org/changeset/ports/411512

Log:
  net-mgmt/guifi-snpservices: Update to 0.2.2.8

  PR:		206405

Changes:
  head/net-mgmt/guifi-snpservices/Makefile
  head/net-mgmt/guifi-snpservices/distinfo
  head/net-mgmt/guifi-snpservices/files/patch-common-ping.sh
  head/net-mgmt/guifi-snpservices/files/patch-common-refresh_mrtg.php
  head/net-mgmt/guifi-snpservices/files/patch-graphs-mrtgcsv2mrtgcfg.php
  head/net-mgmt/guifi-snpservices/files/pkg-message.in
  head/net-mgmt/guifi-snpservices/pkg-plist
Comment 9 Mark Felder freebsd_committer freebsd_triage 2016-03-20 18:41:08 UTC
Committed, thanks!