Bug 206476 - [patch][maintainer update] science/p5-Mcstas-Tools Don't leave dead symlinks when deinstalling
Summary: [patch][maintainer update] science/p5-Mcstas-Tools Don't leave dead symlinks ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Mathieu Arnold
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-01-21 22:02 UTC by Erik B Knudsen
Modified: 2016-04-14 10:41 UTC (History)
1 user (show)

See Also:

Attachments
diff generated by svn (1.42 KB, patch)
2016-01-21 22:02 UTC, Erik B Knudsen 		rakuco: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Erik B Knudsen 2016-01-21 22:02:21 UTC 
Created attachment 165928 [details]
diff generated by svn

installed symbolic links were not cleaned up correctly on deinstall.
Added a pkg-deinstall.in script in files to handle this.
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2016-03-20 11:13:28 UTC 
It would be better to get rid of pkg-install.in and do the following:
- Have a post-install target in Makefile that creates the symlinks.
- Include the symlinks in pkg-plist
- use PLIST_SUB on the PORTVERSION variable

pkg-install.in is a device to allow for actions which can't be foreseen at build time, but (at least in the current version) this does not apply to this port.
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-04-14 10:41:27 UTC 
A commit references this bug:

Author: mat
Date: Thu Apr 14 10:40:38 UTC 2016
New revision: 413251
URL: https://svnweb.freebsd.org/changeset/ports/413251

Log:
  Don't leave dead symlinks when deinstalling. [1] (based on)

  While there, move man pages to a place they can be used, and fix
  shebangs.

  PR:		206476 [1]
  Submitted by:	maintainer
  Sponsored by:	Absolight

Changes:
  head/science/p5-Mcstas-Tools/Makefile
  head/science/p5-Mcstas-Tools/files/
  head/science/p5-Mcstas-Tools/pkg-plist
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2016-04-14 10:41:38 UTC 
Committed a completely different patch, but one that does it right.
Also, fixed a few things while I was there.