Created attachment 166106 [details] armv6 fix Hi, The latest upgrade (r403835) broke the build on armv6, the attached patch fixes that.
Created attachment 166107 [details] poudriere testport log
CC committer of r403835
Hi Mikael, thank you for your patch! Could you be a bit more specific about what was broken and how you fixed it? A two-sentences description would be useful “just for the record”. Unfortunately, I have no ARMv6 by here, where I could test this. I reviewed your patch and it looks good to me. I have however one question: if I understand correctly, the patch adds profiling libraries to the plist. But if I remember correctly, profiling libraries used no to be available on armv6, see [1]. Could you comment on this? Thanks! [1]: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200102#c13
I'm trying to solve this error: http://beefy8.nyi.freebsd.org/data/head-armv6-default/p406714_s293048/logs/errors/ocaml-4.02.3.log Building the profiling libraries on armv6 is just a matter of adding the missing bits in the configure script, I didn't know that in PR 200102
Thank you for your quick feedback Mikael. AFAIC we can merge this, but maybe wen has further comments?
Hi, even with the patch from Mikael ocaml will not build when x11 is deselected. Tested on the latest FreeBSD-11.0-CURRENT-arm-armv6-RPI2-20160217-r295683 it stops with ===> ocaml-lablgl-1.05,1 conflicts with installed package(s): ocaml-nox11-4.02.3 They will not build together. Please remove them first with pkg delete.
Actually, this shows that OCaml has been compiled on your system. You seem to face a totally unrelated that should be resolved by recompiling OCaml with X11 support.
Hi, I've tested your patch on a raspberry pi2, I compiled the net/unison-text port and it works fine. Let me test this a little further so I can commit it.
(In reply to Guido Falsi from comment #8) > Hi, > > I've tested your patch on a raspberry pi2, I compiled the net/unison-text > port and it works fine. > > Let me test this a little further so I can commit it. obviously if you approve the patch.
I have done a round of testing in poudriere and this patch does not brake the port in any way and does make it package correctly on armv6. So If The maintainer states his approval, and there are no objections, I'd commit it to the tree. Thanks.
> So If The maintainer states his approval, and there are no objections, I'd commit it to the tree. Yes Ia m fine with merging this (as fine as in #5). Thanks! :)
Committed. Thanks!
A commit references this bug: Author: madpilot Date: Thu Mar 24 20:55:15 UTC 2016 New revision: 411811 URL: https://svnweb.freebsd.org/changeset/ports/411811 Log: Fix packaging on armv6 by enabling profiling libraries. PR: 206615 Submitted by: mikael.urankar at gmail.com Approved by: michipili at gmail.com (maintainer) Changes: head/lang/ocaml/Makefile head/lang/ocaml/files/patch-configure