Bug 206739 - devel/zookeeper fix link pointing to STAGEDIR and other fixes
Summary: devel/zookeeper fix link pointing to STAGEDIR and other fixes
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steven Kreuzer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-29 17:16 UTC by Pawel Pekala
Modified: 2016-01-30 21:48 UTC (History)
1 user (show)

See Also:
pawel: maintainer-feedback+

Attachments
link & other fixes (1.86 KB, patch)
2016-01-29 17:16 UTC, Pawel Pekala 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pekala freebsd_committer freebsd_triage 2016-01-29 17:16:21 UTC 
Created attachment 166273 [details]
link & other fixes

- Fix link pointing to STAGEDIR after install

====> Running Q/A tests (stage-qa)
Error: Bad symlink 'share/java/classes/zookeeper.jar' pointing inside the stage directory
*** Error code 1

- Add NO_ARCH
- There's no need to include bsd.port.pre.mk
- Use options helper
- Remove deprecated @dirrmtry from pkg-plist
Comment 1 Johan Ström 2016-01-30 09:11:46 UTC 
Just want to make it clear that the port is unusable due to this issue:

lrwxr-xr-x  1 root  wheel       94 Jan 30 09:53 zookeeper.jar -> /wrkdirs/usr/ports/devel/zookeeper/work/stage/usr/local/share/java/classes/zookeeper-3.4.7.jar


# env rc_debug=1 ../rc.d/zookeeper onestart                                                                                                                            
../rc.d/zookeeper: DEBUG: Sourcing /etc/defaults/rc.conf
../rc.d/zookeeper: DEBUG: checkyesno: zookeeper_enable is set to YES.
../rc.d/zookeeper: DEBUG: run_rc_command: start_precmd: zookeeper_init 
Starting zookeeper.
../rc.d/zookeeper: DEBUG: run_rc_command: doit: su -m zookeeper -c 'sh -c "/usr/sbin/daemon  -p /var/run/zookeeper.pid /usr/local/openjdk7/bin/java -Dzookeeper.log.dir=/var/log/zookeeper             -Dlog4j.configuration=file:/usr/local/etc/zookeeper/log4j.properties             -Dzookeeper.root.logger=INFO,ROLLINGFILE -cp /usr/local/share/slf4j/slf4j-log4j12.jar:/usr/local/share/java/classes/log4j.jar:/usr/local/share/java/classes/netty.jar:/usr/local/share/java/classes/slf4j-api.jar:/usr/local/share/java/classes/jline.jar:/usr/local/share/java/classes/zookeeper.jar: org.apache.zookeeper.server.quorum.QuorumPeerMain /usr/local/etc/zookeeper/zoo.cfg"'
Error: Could not find or load main class org.apache.zookeeper.server.quorum.QuorumPeerMain
#
Comment 2 Steven Kreuzer freebsd_committer freebsd_triage 2016-01-30 15:16:29 UTC 
Pawel-

I am not going to be near a computer for a bit. Please go ahead and commit this.

Thanks
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-01-30 21:11:22 UTC 
A commit references this bug:

Author: pawel
Date: Sat Jan 30 21:11:04 UTC 2016
New revision: 407552
URL: https://svnweb.freebsd.org/changeset/ports/407552

Log:
  - Fix link pointing to STAGEDIR after install, this fixes runtime error:

  /jline.jar:/usr/local/share/java/classes/zookeeper.jar:
  org.apache.zookeeper.server.quorum.QuorumPeerMain
  /usr/local/etc/zookeeper/zoo.cfg"'
  Error: Could not find or load main class
  org.apache.zookeeper.server.quorum.QuorumPeerMain

  - Add NO_ARCH
  - There's no need to include bsd.port.pre.mk
  - Use options helper
  - Remove deprecated @dirrmtry from pkg-plist

  PR:		206739
  Submitted by:	myself
  Approved by:	maintainer
  MFH:		2016Q1

Changes:
  head/devel/zookeeper/Makefile
  head/devel/zookeeper/pkg-plist