Bug 206941 - devel/capstone: adding new port for devel/capstone4 and adapting devel/capstone
Summary: devel/capstone: adding new port for devel/capstone4 and adapting devel/capstone
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks: 206942
  Show dependency treegraph
 
Reported: 2016-02-05 06:49 UTC by oleksii.tsai
Modified: 2016-07-10 12:58 UTC (History)
2 users (show)

See Also:
pi: maintainer-feedback-


Attachments
Patch for devel/capstone. (501 bytes, patch)
2016-02-05 06:49 UTC, oleksii.tsai
no flags Details | Diff
New port devel/capstone4 (3.97 KB, patch)
2016-02-05 06:50 UTC, oleksii.tsai
no flags Details | Diff
devel/capstone build log for 9.3-amd64 (15.28 KB, text/plain)
2016-02-05 06:51 UTC, oleksii.tsai
no flags Details
devel/capstone build log for 10.2-amd64 (15.14 KB, text/plain)
2016-02-05 06:51 UTC, oleksii.tsai
no flags Details
devel/capstone4 build log for 9.3-amd64 (15.21 KB, text/plain)
2016-02-05 06:52 UTC, oleksii.tsai
no flags Details
devel/capstone4 build log for 10.2-amd64 (15.48 KB, text/plain)
2016-02-05 06:53 UTC, oleksii.tsai
no flags Details
devel/py-capstone build log for 9.3-amd64 (22.40 KB, text/plain)
2016-02-05 06:53 UTC, oleksii.tsai
no flags Details
devel/py-capstone build log for 10.2-amd64 (22.28 KB, text/plain)
2016-02-05 06:53 UTC, oleksii.tsai
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description oleksii.tsai 2016-02-05 06:49:50 UTC
Created attachment 166593 [details]
Patch for devel/capstone.

Proposed patches add a new port for capstone4 and set PKGNAMESUFFIX to 3 for existing devel/capstone to distinguish it from another major version.
Despite the fact that capstone4 is still not the final stable release devel/radare2 (which is already in ports tree) is using capstone v4.

According to 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205862
we'd like to make radare2 build use system's capstone and not declare a conflict on capstone.

Attaching build logs for ports and dependents of devel/capstone.
Comment 1 oleksii.tsai 2016-02-05 06:50:29 UTC
Created attachment 166594 [details]
New port devel/capstone4
Comment 2 oleksii.tsai 2016-02-05 06:51:19 UTC
Created attachment 166595 [details]
devel/capstone build log for 9.3-amd64
Comment 3 oleksii.tsai 2016-02-05 06:51:56 UTC
Created attachment 166596 [details]
devel/capstone build log for 10.2-amd64
Comment 4 oleksii.tsai 2016-02-05 06:52:26 UTC
Created attachment 166597 [details]
devel/capstone4 build log for 9.3-amd64
Comment 5 oleksii.tsai 2016-02-05 06:53:00 UTC
Created attachment 166598 [details]
devel/capstone4 build log for 10.2-amd64
Comment 6 oleksii.tsai 2016-02-05 06:53:32 UTC
Created attachment 166599 [details]
devel/py-capstone build log for 9.3-amd64
Comment 7 oleksii.tsai 2016-02-05 06:53:59 UTC
Created attachment 166600 [details]
devel/py-capstone build log for 10.2-amd64
Comment 8 Kurt Jaeger freebsd_committer freebsd_triage 2016-02-07 10:29:45 UTC
Would you mind if we moved capstone to capstone3 ? The dependend port list is limited to devel/py-capstone, so if we fix that dependency as well...
Comment 9 oleksii.tsai 2016-02-07 19:08:15 UTC
(In reply to Kurt Jaeger from comment #8)
I don't have any objections. The reason i went this way is I was thinking about devel/capstone tracking latest stable version. devel/capstone4 is sort of an exception (workaround) as it not stable yet, however, already in use. I guess our options are:
1) devel/capstone tracks stable releases (v3 for now), devel/capstone4 becomes essentially devel/capstone-devel

or

2) rename devel/capstone to devel/capstone3, keep devel/capstone4 and then keep adding new ports for any new major version.

Option 1 is easier on porter's side, however, looking at capstone project they actually have various development branches which drastically differ, so not clear which one to track.

Option 2 provides more variety to users and some flexibility to port maintainers in case there are some outdated ports that use (or will use) capstone. And actually nothing stops having devel/capstone in this case too.

Option 2 seems better to me now.
Comment 10 Kurt Jaeger freebsd_committer freebsd_triage 2016-02-08 18:33:24 UTC
(In reply to oleksii.tsai from comment #9)
I think I already confirmed by mail that 2) is preferred 8-)

I'm a bit busy right now, will get back to this ticket later. Or someone
else beats me to it 8-)
Comment 11 commit-hook freebsd_committer freebsd_triage 2016-07-10 12:57:47 UTC
A commit references this bug:

Author: pi
Date: Sun Jul 10 12:57:27 UTC 2016
New revision: 418316
URL: https://svnweb.freebsd.org/changeset/ports/418316

Log:
  devel/capstone: move to capstone3, introduce capstone4

  - update py-capstone to use capstone3

  PR:		206941
  Submitted by:	oleksii.tsai@gmail.com
  Approved by:	oliver.pntr@gmail.com (maintainer timeout)

Changes:
  head/MOVED
  head/devel/Makefile
  head/devel/capstone/
  head/devel/capstone3/
  head/devel/capstone3/Makefile
  head/devel/capstone4/
  head/devel/capstone4/Makefile
  head/devel/capstone4/distinfo
  head/devel/capstone4/pkg-plist
  head/devel/py-capstone/Makefile
Comment 12 Kurt Jaeger freebsd_committer freebsd_triage 2016-07-10 12:58:47 UTC
Committed, thanks! Uff, this took too long 8-(