Bug 206960 - www/py-beaker: Missing dependency: py-funcsigs (< Python 3.3)
Summary: www/py-beaker: Missing dependency: py-funcsigs (< Python 3.3)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vanilla I. Shu
URL:
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2016-02-05 23:11 UTC by freebsd
Modified: 2016-03-07 02:06 UTC (History)
1 user (show)

See Also:
koobs: merge-quarterly?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description freebsd 2016-02-05 23:11:53 UTC 
in beaker/_compat.py at line 160 it says:

try:
    from inspect import signature as func_signature
except ImportError:
    from funcsigs import signature as func_signature

The inspect package doesn't include signature() until python 3.3 so it
looks for funcsigs, and fails if that package isn't installed.

The solution is easy, add py-funcsigs as a prerequisite, at least if it's being built for python 2.x.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-02-06 17:35:37 UTC 
As per setup.py:

if not hasattr(inspect, 'signature'):
    # On Python 2.6, 2.7 and 3.2 we need funcsigs dependency
    INSTALL_REQUIRES.append('funcsigs')

.if ${PYTHON_REL} < 3300
Comment 2 freebsd 2016-02-06 19:13:58 UTC 
You're right, setup.py says that, but I've installed it on both 9.3 and 10.2,
and it doesn't pull in funcsigs or complain if it's not there.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-03-07 02:06:28 UTC 
A commit references this bug:

Author: vanilla
Date: Mon Mar  7 02:06:02 UTC 2016
New revision: 410496
URL: https://svnweb.freebsd.org/changeset/ports/410496

Log:
  Add RUN_DEPENDS to py-funcsigs.

  PR:		206960
  Submitted by:	freebsd@johnlevine.com

Changes:
  head/www/py-beaker/Makefile