Bug 207015 - textproc/libabw: fix build with boost 1.60
Summary: textproc/libabw: fix build with boost 1.60
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jung-uk Kim
URL:
Keywords:
Depends on:
Blocks: 199601
  Show dependency treegraph
 
Reported: 2016-02-08 11:25 UTC by Dmitry Marakasov
Modified: 2016-02-25 20:22 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (office)


Attachments
Patch (558 bytes, patch)
2016-02-08 11:25 UTC, Dmitry Marakasov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2016-02-08 11:25:07 UTC
Created attachment 166738 [details]
Patch

Link error when building with boost 1.60, fixed by adding boost_system to link libraries. See also https://wiki.freebsd.org/BoostPortingProject/1.55-to-1.60
Comment 1 Jung-uk Kim freebsd_committer freebsd_triage 2016-02-25 19:51:04 UTC
I'll take it.
Comment 2 Jung-uk Kim freebsd_committer freebsd_triage 2016-02-25 20:12:29 UTC
Usually, there is no need to add dependency for libboost_system.so.  Often times, all you need is adding "-DBOOST_ERROR_CODE_HEADER_ONLY" and "-DBOOST_SYSTEM_NO_DEPRECATED" to CPPFLAGS or CXXFLAGS.  In fact, the upstream did that.

https://gerrit.libreoffice.org/gitweb?p=libabw.git;a=commitdiff;h=ee2d072
https://gerrit.libreoffice.org/gitweb?p=libabw.git;a=commitdiff;h=9bd64c2
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-02-25 20:18:41 UTC
A commit references this bug:

Author: jkim
Date: Thu Feb 25 20:18:17 UTC 2016
New revision: 409554
URL: https://svnweb.freebsd.org/changeset/ports/409554

Log:
  - Add an upstream patch to fix build with Boost 1.59 and later. [1]
  - Update the project URL.
  - Make portlint happy.

  PR:		207015 [1]

Changes:
  head/textproc/libabw/Makefile
  head/textproc/libabw/files/patch-libabw.pc.in
  head/textproc/libabw/files/patch-src_lib_Makefile.in
  head/textproc/libabw/pkg-descr
Comment 4 Jung-uk Kim freebsd_committer freebsd_triage 2016-02-25 20:22:26 UTC
Committed the upstream patch.