Bug 207041 - lang/ficl bring some fixes from GSoC 2015
Summary: lang/ficl bring some fixes from GSoC 2015
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Raphael Kubo da Costa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-09 03:31 UTC by Pedro F. Giffuni
Modified: 2016-03-05 19:08 UTC (History)
2 users (show)

See Also:
pavelivolkov: maintainer-feedback+


Attachments
Add patches with fixes (9.10 KB, patch)
2016-02-09 03:31 UTC, Pedro F. Giffuni
no flags Details | Diff
Patches from SoC 2015. Many thanks Pedro F. Giffuni. (9.60 KB, patch)
2016-02-22 13:24 UTC, Pavel Volkov
pavelivolkov: maintainer-approval+
Details | Diff
It's log of build this port. (5.47 KB, text/plain)
2016-02-22 13:25 UTC, Pavel Volkov
no flags Details
portlint log file for this a port (12.49 KB, text/plain)
2016-02-22 13:26 UTC, Pavel Volkov
no flags Details
merged patch (9.93 KB, patch)
2016-03-05 18:12 UTC, Pedro F. Giffuni
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro F. Giffuni freebsd_committer freebsd_triage 2016-02-09 03:31:09 UTC
Created attachment 166781 [details]
Add patches with fixes

There was a GSoC 2015 from Colin Lord to bring to the base system a recent version of Ficl. It found many bugs in ficl4.

Among them:
- Fix ficlInstructionPick bug. Pick instructions from 0, not 1.
Credit to Toomas Soome from the Illumos project.
- Fix some math bugs.
Credit to Toomas Soome from the Illumos project.
- Fix bug in Ficl stack preventing the stack from growing.
Obtained from:	http://sourceforge.net/p/ficl/mailman/message/26634755/
- Change rand and srand calls to random and srandom
Submitted by: pfg

It would be nice to bring these fixes to the port.
Pet portlint while here.
Comment 1 Pedro F. Giffuni freebsd_committer freebsd_triage 2016-02-09 18:45:21 UTC
Comment on attachment 166781 [details]
Add patches with fixes

(Set as diff: for some reason attaching files from chromium is not working properly)
Comment 2 Pavel Volkov 2016-02-22 13:24:18 UTC
Created attachment 167296 [details]
Patches from SoC 2015. Many thanks Pedro F. Giffuni.

Hello.
Thank you very much for your attention.
Comment 3 Pavel Volkov 2016-02-22 13:25:51 UTC
Created attachment 167297 [details]
It's log of build this port.
Comment 4 Pavel Volkov 2016-02-22 13:26:14 UTC
Created attachment 167298 [details]
portlint log file for this a port
Comment 5 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-03-03 10:43:14 UTC
(In reply to Pavel Volkov from comment #2)
> Created attachment 167296 [details]
> Patches from SoC 2015. Many thanks Pedro F. Giffuni.
> 
> Hello.
> Thank you very much for your attention.

The patch doesn't look entirely right: it's at least creating a patch-ficl.h in the port's top-level directory.
Comment 6 Pedro F. Giffuni freebsd_committer freebsd_triage 2016-03-03 18:50:38 UTC
(In reply to Raphael Kubo da Costa from comment #5)

Yes, the problem seems to be only in the latest diff.
My original patch doesn't have it:

% svn status lang/ficl
M       lang/ficl/files/patch-dictionary.c
A       lang/ficl/files/patch-double.c
M       lang/ficl/files/patch-ficl.h
M       lang/ficl/files/patch-float.c
M       lang/ficl/files/patch-primitives.c
M       lang/ficl/files/patch-tools.c
A       lang/ficl/files/patch-vm.c
M       lang/ficl/pkg-descr
Comment 7 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-03-05 11:51:38 UTC
It'd be great if someone could submit a final version then. Pedro's original patch is almost complete, but doesn't change Makefile. Pavel's patch has an additional file that shouldn't be created, and I don't get the removal of the DOCS option (it's the DATA one that doesn't seem to have any effect). Additionally, it looks like MAKE_JOBS_UNSAFE=yes can be removed too.
Comment 8 Pedro F. Giffuni freebsd_committer freebsd_triage 2016-03-05 18:12:41 UTC
Created attachment 167740 [details]
merged patch

OK, I merged the Makefile changes and followed the suggestions:

% portlint
looks fine.
% make check-plist
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
Comment 9 commit-hook freebsd_committer freebsd_triage 2016-03-05 19:08:33 UTC
A commit references this bug:

Author: rakuco
Date: Sat Mar  5 19:07:35 UTC 2016
New revision: 410201
URL: https://svnweb.freebsd.org/changeset/ports/410201

Log:
  Bring in some fixes from GSoC 2015.

  There was a GSoC 2015 from Colin Lord to bring to the base system a recent
  version of Ficl. pfg@ found many bugs in ficl4.

  Among them:
  - Fix ficlInstructionPick bug. Pick instructions from 0, not 1.
  Credit to Toomas Soome from the Illumos project.
  - Fix some math bugs.
  Credit to Toomas Soome from the Illumos project.
  - Fix bug in Ficl stack preventing the stack from growing.
  Obtained from:    http://sourceforge.net/p/ficl/mailman/message/26634755/
  - Change rand and srand calls to random and srandom

  Fix those in the port. While here, unset MAKE_JOBS_UNSAFE as the port builds
  fine without it, and get rid of the DATA option that has no effect.

  PR:		207041
  Submitted by:	pfg
  Approved by:	Pavel Volkov <pavelivolkov@gmail.com> (maintainer)

Changes:
  head/lang/ficl/Makefile
  head/lang/ficl/files/patch-dictionary.c
  head/lang/ficl/files/patch-double.c
  head/lang/ficl/files/patch-ficl.h
  head/lang/ficl/files/patch-float.c
  head/lang/ficl/files/patch-primitives.c
  head/lang/ficl/files/patch-tools.c
  head/lang/ficl/files/patch-vm.c
  head/lang/ficl/pkg-descr
Comment 10 Raphael Kubo da Costa freebsd_committer freebsd_triage 2016-03-05 19:08:55 UTC
Finally landed, thanks guys!