Bug 207139 - [patch] deskutils/owncloudclient: Update to 2.1.1
Summary: [patch] deskutils/owncloudclient: Update to 2.1.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-02-12 22:09 UTC by Guido Falsi
Modified: 2016-02-18 07:55 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (yonas)


Attachments
Update patch (4.62 KB, patch)
2016-02-12 22:09 UTC, Guido Falsi
madpilot: maintainer-approval? (yonas)
Details | Diff
Upgrade patch, should apply cleanly (4.77 KB, patch)
2016-02-16 16:17 UTC, Yonas Yanfa
yonas: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2016-02-12 22:09:22 UTC
Created attachment 166910 [details]
Update patch

Hi,

I'm attaching a patch to update owncloudclient to 2.1.1.

IN the patch I also change the distribution download to use github and take advantage of the localbase USES.

Can you review and, if you see fit, approve this patch?

Thanks!
Comment 1 Yonas Yanfa 2016-02-12 22:23:05 UTC
Hi Guido,

Thanks for the patch, much appreciated! I'll take a look at this asap.

Cheers,
Yonas
Comment 2 Yonas Yanfa 2016-02-13 22:56:36 UTC
I've applied the patch, but I'm getting the following error when running `make -DBATCH`:

Attempting to fetch https://codeload.github.com/owncloud/client/tar.gz/v2.1.1?dummy=/owncloud-client-v2.1.1_GH0.tar.gz
)etch: invalid size (13873040
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2016-02-14 11:52:05 UTC
(In reply to Yonas Yanfa from comment #2)

Strange error.

First of all are you sure the patch applied cleanly?

Could I see the full log of the error? This is just a small part of it, I'm not sure what is the cause.

Could be something wrong in the distfiles file or an error with the download itself.
Comment 4 Yonas Yanfa 2016-02-16 11:43:35 UTC
The patch didn't apply cleanly, so I manually patched it and that seems to have fixed it.

It's going to take a while for everything to compile. I'll update here when it's done and tested.
Comment 5 Yonas Yanfa 2016-02-16 16:17:25 UTC
Created attachment 167082 [details]
Upgrade patch, should apply cleanly

This looks good. I've attached a patch that should apply cleanly.
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2016-02-18 07:55:32 UTC
Committed! Thanks.
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-02-18 07:55:56 UTC
A commit references this bug:

Author: madpilot
Date: Thu Feb 18 07:55:17 UTC 2016
New revision: 409095
URL: https://svnweb.freebsd.org/changeset/ports/409095

Log:
  - Update to 2.1.1
  - Convert to USE_GUTHUB
  - Take advantage od USES=localbase
  - Convert to USES=sqlite

  PR:		207139
  Submitted by:	me
  Approved by:	Yonas Yanfa <yonas at fizk.net>

Changes:
  head/deskutils/owncloudclient/Makefile
  head/deskutils/owncloudclient/distinfo
  head/deskutils/owncloudclient/pkg-plist