Bug 207190 - [PATCH] x11-fm/xdiskusage: correct wrong df(1) parameters
Summary: [PATCH] x11-fm/xdiskusage: correct wrong df(1) parameters
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-02-14 15:51 UTC by Kalten
Modified: 2016-03-28 00:46 UTC (History)
0 users

See Also:

Attachments
calling df(1) with correct parameters for FreeBSD (430 bytes, patch)
2016-02-14 15:51 UTC, Kalten 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kalten 2016-02-14 15:51:52 UTC 
Created attachment 166987 [details]
calling df(1) with correct parameters for FreeBSD

In FreeBSD the invocation parameters for df(1) lead to an error, as »-x«
(‘exclude’ in Linux) is not known.
I think they want something like »-t noprocfs,devfs,fdescfs« (see manual
page df(1)—strangely enough the prefix »no« applies to all following
entries).

I have filed this patch to the developers as well
https://sourceforge.net/p/xdiskusage/patches/10/
But it may take quite some time for them to take care of it.

Regards,
 Kalten
Comment 1 Kalten 2016-02-17 01:00:15 UTC 
The Author has committed my suggested patch to the git repository.

Should we use this latest version on git://git.code.sf.net/p/xdiskusage/git
275754ad0a24716d86da1aaaf452b0906211e859 (solving other mistakes too)
instead of patching in the ports tree?

Should we set PORTVERSION=1.51.5 as it is the fifth fix since 1.51—if I am
not mistaken?

Regards,
 Kalten
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2016-03-28 00:45:03 UTC 
(In reply to Kalten from comment #1)

> Should we use this latest version on git://git.code.sf.net/p/xdiskusage/git
> 275754ad0a24716d86da1aaaf452b0906211e859 (solving other mistakes too)
> instead of patching in the ports tree?

We prefer not to use VCS snapshots. These may be broken and unstable, and we'll have to maintain and host the distfile ourselves. It's better to ask upstream to release a new version sooner.

> Should we set PORTVERSION=1.51.5 as it is the fifth fix since 1.51—if I am
> not mistaken?

No, PORTVERSION refers to upstream version, and there's no such thing as xdiskusage 1.51.5. We have PORTREVISION for this case (e.g. to mark a port update which does not involve switching to newer upstream version).
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-03-28 00:46:37 UTC 
A commit references this bug:

Author: amdmi3
Date: Mon Mar 28 00:46:12 UTC 2016
New revision: 412024
URL: https://svnweb.freebsd.org/changeset/ports/412024

Log:
  - Fix incorrect df command invocation which makes the port unusable
  - While here, silence patching and clean up pkg-descr

  PR:		207190
  Submitted by:	kalten@gmx.at

Changes:
  head/x11-fm/xdiskusage/Makefile
  head/x11-fm/xdiskusage/files/
  head/x11-fm/xdiskusage/files/patch-xdiskusage.C
  head/x11-fm/xdiskusage/pkg-descr