Bug 207426 - deskutils/gnome-contacts: does not build with CHEESE option off
Summary: deskutils/gnome-contacts: does not build with CHEESE option off
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-22 22:05 UTC by John Marino
Modified: 2016-10-22 21:18 UTC (History)
3 users (show)

See Also:
miwi: maintainer-feedback? (gnome)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer freebsd_triage 2016-02-22 22:05:31 UTC 
with CHEESE option turned off, gnome-contacts fails to build:

  CC       contacts-accounts-list.o
In file included from contacts-avatar-dialog.c:27:0:
./cheese-flash.h:67:34: fatal error: cheese/cheese-widget.h: No such file or directory


This is on DragonFly but I expect that it can be reproduced on FreeBSD.
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2016-02-23 01:27:59 UTC 
Forward to maintainer.
Comment 2 Marko Cupać 2016-03-01 07:46:33 UTC 
(In reply to John Marino from comment #0)

I reproduced it in FreeBSD, this is from poudriere jail 10.2-RELEASE-p12 amd64:

  CC       contacts-avatar-dialog.o
In file included from contacts-avatar-dialog.c:27:
./cheese-flash.h:67:10: fatal error: 'cheese/cheese-widget.h' file not found
#include <cheese/cheese-widget.h>
Comment 3 John Marino freebsd_committer freebsd_triage 2016-03-13 12:00:31 UTC 
has anyone from gnome@ taken a look at this?
Comment 4 John Marino freebsd_committer freebsd_triage 2016-05-30 14:07:02 UTC 
(silence after 2.5 months)

At least remove the CHEESE option and make CHEESE a mandatory dependency rather than leaving the status quo ...
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-09-04 20:53:53 UTC 
A commit references this bug:

Author: marino
Date: Sun Sep  4 20:52:52 UTC 2016
New revision: 421349
URL: https://svnweb.freebsd.org/changeset/ports/421349

Log:
  deskutils/gnome-contacts: remove CHEESE option

  Since version 3.18 was introduced (Feb 2016), it's not been possible to
  build gnome-contacts with the CHEESE option turned off.  Since it appears
  to be required now, remove this option and set the configuration and
  dependencies for cheese unconditionally.

  PR:		207426
  Approved by:	maintainer timeout (6.5 months)

Changes:
  head/deskutils/gnome-contacts/Makefile
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-10-22 21:18:29 UTC 
A commit references this bug:

Author: marino
Date: Sat Oct 22 21:18:12 UTC 2016
New revision: 424488
URL: https://svnweb.freebsd.org/changeset/ports/424488

Log:
  deskutils/gnome-contacts: restore CHEESE option

  Since version 3.18, the  --without-cheese configuration argument didn't
  work out of the box.  However, touching a couple of files causes c source
  files to be regenerated enabling the option to be honored.

  This commit restores the options as they were before r421349 but now
  disabling the default CHEESE option works.

  PR:		207426
  Approved by:	follow-on commit (r421349)

Changes:
  head/deskutils/gnome-contacts/Makefile