Bug 207436 - multimedia/emby-server: Fix problem with timezone being set to UTC
Summary: multimedia/emby-server: Fix problem with timezone being set to UTC
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Thomas Zander
URL: http://emby.media/community/index.php...
Keywords: easy, patch
Depends on:
Blocks: 207500
  Show dependency treegraph
 
Reported: 2016-02-23 09:24 UTC by Ben Woods
Modified: 2016-02-29 06:28 UTC (History)
2 users (show)

See Also:
riggs: merge-quarterly+


Attachments
Patch to fix multimedia/emby-server timezone issue and remove pkg-install (1.78 KB, patch)
2016-02-23 09:24 UTC, Ben Woods
woodsb02: maintainer-approval+
Details | Diff
QA: Successful poudriere testport logs for emby-server 3.0.5821_1 on FreeBSD 10.2 amd64 (gzipped) (106.29 KB, application/gzip)
2016-02-23 09:34 UTC, Ben Woods
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Woods freebsd_committer freebsd_triage 2016-02-23 09:24:20 UTC
Created attachment 167318 [details]
Patch to fix multimedia/emby-server timezone issue and remove pkg-install

* Remove the setting of the TZ, LC_ALL and LANG shell variables from rc script. This resolves an issue where the emby-server timezone was set to UTC, causing show air dates and TV guides to be off by a number of hours for some users [1]. Setting these variables was originally added when mono 3.12.1 was in the ports tree, to avoid mono throwing a number of System.TimeZoneNotFound exceptions when run in debugging mode [2]. Whilst these exceptions are still thrown, they are caught and the mono code now only sets the time to UTC if the correct timezone cannot be found from the TZ variable or /etc/localtime.

* Remove pkg-install script as it is no longer necessary to download Mozilla's root certificates and import them into the Mono Trust store (this was actually never effective, as the certificates were saved into the root user's mono trust store instead of the emby user's store).

* Bump PORTREVISION


 [1] http://emby.media/community/index.php?/topic/13083-freenas-plugin/?p=299783
 [2] mono --debug --trace=N:nothing /usr/local/lib/emby-server/MediaBrowser.Server.Mono.exe -ffmpeg /usr/local/bin/ffmpeg -ffprobe /usr/local/bin/ffprobe -programdata /var/db/emby-server
Comment 1 Ben Woods freebsd_committer freebsd_triage 2016-02-23 09:34:27 UTC
Created attachment 167319 [details]
QA: Successful poudriere testport logs for emby-server 3.0.5821_1 on FreeBSD 10.2 amd64 (gzipped)
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-02-28 11:48:50 UTC
A commit references this bug:

Author: riggs
Date: Sun Feb 28 11:48:09 UTC 2016
New revision: 409735
URL: https://svnweb.freebsd.org/changeset/ports/409735

Log:
  Respect timezone settings, remove unnecessary pkg-install script

  Detailed maintainer log:
  - Remove the setting of the TZ, LC_ALL and LANG shell variables from rc
    script.  This resolves an issue where the emby-server timezone was set to
    UTC, causing show air dates and TV guides to be off by a number of hours
    for some users [1]. Setting these variables was originally added when
    mono 3.12.1 was in the ports tree, to avoid mono throwing a number of
    System.TimeZoneNotFound exceptions when run in debugging mode [2]. Whilst
    these exceptions are still thrown, they are caught and the mono code now
    only sets the time to UTC if the correct timezone cannot be found from
    the TZ variable or /etc/localtime.
  - Remove pkg-install script as it is no longer necessary to download
    Mozilla's root certificates and import them into the Mono Trust store
    (this was actually never effective, as the certificates were saved into
    the root user's mono trust store instead of the emby user's store).
  - Bump PORTREVISION

  [1] http://emby.media/community/index.php?/topic/13083-freenas-plugin/?p=299783
  [2] mono --debug --trace=N:nothing /usr/local/lib/emby-server/MediaBrowser.Server.Mono.exe -ffmpeg /usr/local/bin/ffmpeg -ffprobe /usr/local/bin/ffprobe -programdata /var/db/emby-server

  PR:		207436
  Submitted by:	woodsb02@gmail.com (maintainer)
  MFH:		2016Q1

Changes:
  head/multimedia/emby-server/Makefile
  head/multimedia/emby-server/files/emby-server.in
  head/multimedia/emby-server/pkg-install
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-02-29 06:17:49 UTC
A commit references this bug:

Author: riggs
Date: Mon Feb 29 06:17:33 UTC 2016
New revision: 409801
URL: https://svnweb.freebsd.org/changeset/ports/409801

Log:
  MFH: r409735

  Respect timezone settings, remove unnecessary pkg-install script

  Detailed maintainer log:
  - Remove the setting of the TZ, LC_ALL and LANG shell variables from rc
    script.  This resolves an issue where the emby-server timezone was set to
    UTC, causing show air dates and TV guides to be off by a number of hours
    for some users [1]. Setting these variables was originally added when
    mono 3.12.1 was in the ports tree, to avoid mono throwing a number of
    System.TimeZoneNotFound exceptions when run in debugging mode [2]. Whilst
    these exceptions are still thrown, they are caught and the mono code now
    only sets the time to UTC if the correct timezone cannot be found from
    the TZ variable or /etc/localtime.
  - Remove pkg-install script as it is no longer necessary to download
    Mozilla's root certificates and import them into the Mono Trust store
    (this was actually never effective, as the certificates were saved into
    the root user's mono trust store instead of the emby user's store).
  - Bump PORTREVISION

  [1] http://emby.media/community/index.php?/topic/13083-freenas-plugin/?p=299783
  [2] mono --debug --trace=N:nothing /usr/local/lib/emby-server/MediaBrowser.Server.Mono.exe -ffmpeg /usr/local/bin/ffmpeg -ffprobe /usr/local/bin/ffprobe -programdata /var/db/emby-server

  PR:		207436
  Submitted by:	woodsb02@gmail.com (maintainer)
  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2016Q1/
  branches/2016Q1/multimedia/emby-server/Makefile
  branches/2016Q1/multimedia/emby-server/files/emby-server.in
  branches/2016Q1/multimedia/emby-server/pkg-install
Comment 4 Thomas Zander freebsd_committer freebsd_triage 2016-02-29 06:28:15 UTC
Thanks for the great commit log! :-)