At the moment the interface plugin is only enabled when you select the "Enable statgrab-based plugins" option. However, since upstream commit 645dadb, which is in Collectd 5.5, the interface plugin works fine without needing to link with libstatgrab. It would be great if the interface plugin was enabled by default, so I don't have to build a custom collectd from ports.
OK, No problem for me :-))) Did you make a patch? Or I should do?
If you could do it that would be great. Thanks!
I need some time to make a patch. As I understand I should add INTERFACE which will activate interface plugin. I have to check current patches to exclude libstatgrab. So please give me some time.
Statgrab is still needed for some other plugins I think, so no need to exclude it.
I double checked and I was wrong, the interface plugin was indeed the only one still using libstatgrab. Patch coming up.
Created attachment 167799 [details] Enable interface plugin by default
I've checked this commit: https://github.com/collectd/collectd/commit/645dadb3fcc466e8880fda4eb23b21ad433631fc As I understand libstatgrab is not needed any more for interface plugin (although https://www.collectd.org/wiki/index.php/Plugin:Interface says that libstatgrab is needed). So I've started working on patch to add INTERFACE option. After testing this patch with poudriere you can test it on production server(s).
(In reply to Ruben Kerkhof from comment #6) We are working together with this problem :-)))
(In reply to Ruben Kerkhof from comment #6) OK. I checked you patch. It seems good. So I think it could be applied. But first please check it and confirm that interface stats are collected correctly. Could you?
Thank you. I just tested it, and it looks good: # /usr/local/sbin/collectd -f [2016-03-07 11:11:15] write_log values: localhost.interface-igb1.if_octets.rx 4855851911 1457349075 localhost.interface-igb1.if_octets.tx 260446947 1457349075 [2016-03-07 11:11:15] write_log values: localhost.interface-igb0.if_octets.rx 5096214974 1457349075 localhost.interface-igb0.if_octets.tx 319590425 1457349075 I'll see if I can correct the entry on the Collectd wiki.
Comment on attachment 167799 [details] Enable interface plugin by default OK, Because it seems that after this patch collected interfaces statistics are OK, I can approve this patch
What happens next? Can you apply it?
No, I'm not committer :-))) Now, I have to test it with poudriere. Also this patch should be done correctly (from ports root dir - /usr/ports as default). I will ask you to depracate you patch after I will put correct one.
Created attachment 167966 [details] patch collectd 5.5.1 - revision 2 So, I've made a patch (correct one). Also this was tested with poudriere - you can check log at https://rtm.bsdserwis.com/poudriere/data/a1amd64-testing/2016-03-10_14h27m53s/logs/collectd5-5.5.1_2.log Ruben, please deprecate your patch so only this one will be applied to ports tree
A commit references this bug: Author: feld Date: Mon Mar 14 22:55:49 UTC 2016 New revision: 411129 URL: https://svnweb.freebsd.org/changeset/ports/411129 Log: net-mgmt/collectd5: enable interface plugin by default The interface plugin no longer requires libstatgrab. PR: 207564 Approved by: maintainer Changes: head/net-mgmt/collectd5/Makefile head/net-mgmt/collectd5/pkg-plist
committed, thanks!