Created attachment 167524 [details] Proposed patch The attached patch updates security/pinentry and its slave ports to 0.9.7, the latest stable release. Compared to 0.9.5, the biggest change is improved support for libc++ in pinentry-qt4, as upstream got rid of its custom entry widget that only worked with libstdc++. This allows the Makefile to be simplified. There's also an option to build a Qt5-based version of pinentry, but I did not add the new port in this patch. Max: since this change affects a lot of people I thought it'd be better to run it by you first. Do you perform any additional tests other than building and running the ports?
(In reply to Raphael Kubo da Costa from comment #0) > Created attachment 167524 [details] > Proposed patch > > The attached patch updates security/pinentry and its slave ports to 0.9.7, > the latest stable release. > > Compared to 0.9.5, the biggest change is improved support for libc++ in > pinentry-qt4, as upstream got rid of its custom entry widget that only > worked with libstdc++. This allows the Makefile to be simplified. Looks fine, thanks! > > There's also an option to build a Qt5-based version of pinentry, but I did > not add the new port in this patch. > > Max: since this change affects a lot of people I thought it'd be better to > run it by you first. OK > Do you perform any additional tests other than building > and running the ports? No any additional test. If it builds fine and works for me, than I extrapolate it's OK for everyone.
A commit references this bug: Author: rakuco Date: Mon Feb 29 18:35:00 UTC 2016 New revision: 409822 URL: https://svnweb.freebsd.org/changeset/ports/409822 Log: Update security/pinentry and slave ports to 0.9.7. From pinentry's NEWS file: Noteworthy changes in version 0.9.7 (2015-12-07) ------------------------------------------------ * Fix regressions in the Qt pinentry. * Fix minor problems pinnetyr-tty. * New option --invisible-char. Noteworthy changes in version 0.9.6 (2015-09-10) ------------------------------------------------ * Many improvements for the dump tty pinentry. * Use the standard GTK+-2 text entry widget instead of our outdated and back-then-it-was-more-secure text widget. * Use the standard Qt text widget. * Allow for building a static Qt variant. * Fix regression in w32 pinentry. Compare to 0.9.5, the biggest change from a ports perspective is improved support for libc++ in pinentry-qt, as upstream got rid of its custom entry widget that only worked with libstdc++. This allows the Makefile to be simplified and pinentry-qt4 to be built with libc++. There is also an option to build a Qt5-based version of pinentry, but I did not add the new port in this patch. PR: 207567 Approved by: makc (maintainer) Changes: head/security/pinentry/Makefile head/security/pinentry/distinfo head/security/pinentry-gnome3/Makefile