Bug 207758 - [NEW PORT] misc/py-pyprind: Python Progress Indicator Utility
Summary: [NEW PORT] misc/py-pyprind: Python Progress Indicator Utility
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kubilay Kocak
URL:
Keywords: easy, feature, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-03-06 23:55 UTC by Neel Chauhan
Modified: 2016-06-30 09:15 UTC (History)
2 users (show)

See Also:


Attachments
Shar file for misc/py-pyprind 2.9.4 (1.55 KB, text/plain)
2016-03-06 23:55 UTC, Neel Chauhan
no flags Details
poudriere build log for misc/py-pyprind 2.9.4 on FreeBSD 10.2 (16.16 KB, text/plain)
2016-03-06 23:56 UTC, Neel Chauhan
no flags Details
poudriere build log for misc/py-pyprind 2.9.4 on FreeBSD 9.3 (103 bytes, text/plain)
2016-03-07 00:01 UTC, Neel Chauhan
no flags Details
Shar file for misc/pyprind 2.9.5 (3.29 KB, text/plain)
2016-03-14 14:34 UTC, Neel Chauhan
no flags Details
poudriere build log for misc/pyprind 2.9.5 on FreeBSD 10.2 (15.14 KB, text/plain)
2016-03-14 14:35 UTC, Neel Chauhan
no flags Details
poudriere build log for misc/pyprind 2.9.5 on FreeBSD 9.3 (14.94 KB, text/plain)
2016-03-14 14:35 UTC, Neel Chauhan
no flags Details
Shar file for misc/pyprind 2.9.5 with regression test (3.47 KB, text/plain)
2016-03-14 15:00 UTC, Neel Chauhan
no flags Details
Shar file for misc/pyprind 2.9.8 (3.06 KB, text/plain)
2016-06-05 13:40 UTC, Neel Chauhan
no flags Details
Poudriere build log for misc/pyprind 2.9.8 on FreeBSD 10.3 amd64 (14.98 KB, text/plain)
2016-06-05 13:41 UTC, Neel Chauhan
no flags Details
Poudriere build log for misc/pyprind 2.9.8 on FreeBSD 10.3 i386 (15.01 KB, text/plain)
2016-06-05 13:47 UTC, Neel Chauhan
no flags Details
Poudriere build log for misc/pyprind 2.9.8 on FreeBSD 9.3 amd64 (14.78 KB, text/plain)
2016-06-05 13:52 UTC, Neel Chauhan
no flags Details
Shar file for misc/py-pyprind 2.9.8 (3.12 KB, text/plain)
2016-06-09 12:10 UTC, Neel Chauhan
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Neel Chauhan freebsd_committer freebsd_triage 2016-03-06 23:55:30 UTC
Created attachment 167784 [details]
Shar file for misc/py-pyprind 2.9.4

Python Progress Indicator Utility

WWW: https://www.github.com/rasbt/pyprind
Comment 1 Neel Chauhan freebsd_committer freebsd_triage 2016-03-06 23:56:19 UTC
Created attachment 167785 [details]
poudriere build log for misc/py-pyprind 2.9.4 on FreeBSD 10.2
Comment 2 Neel Chauhan freebsd_committer freebsd_triage 2016-03-07 00:01:49 UTC
Created attachment 167786 [details]
poudriere build log for misc/py-pyprind 2.9.4 on FreeBSD 9.3
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2016-03-14 06:42:53 UTC
Version 2.9.5 is out, will include this is the update.

Other review/general items & changes:

 * Switch to CHEESESHOP for DISTFILES (for 2.9.5, no repository tag [1]) CHEESESHOP is preferred unless there's a reason to fetch from elsewhere, like if tests are not included in PyPI sdist.

 * CATEGORIES missing 'python' as secondary (virtual) category
 * Match COMMENT to that in setup.py:description:

    Python Progress Bar and Percent Indicator Utility

 * Match pkg-descr WWW: URL to setup.py:url=

    https://github.com/rasbt/pyprind

 * Use setup.py:long_description or equivalent text for pkg-descr:

    The PyPrind (Python Progress Indicator) module provides a progress bar
    and a percentage indicator object that let you track the progress of a
    loop structure or other iterative computation. Typical applications
    include the processing of large data sets to provide an intuitive
    estimate at runtime about the progress of the computation.

 * Can't find reference to 0.5.1, for psutil dependency. Upstream should add psutil as an 'extras_require' to setup.py (create an issue or PR)

 * Patch setup.py to add test dependencies and support setuptools 'test' command. Add an __init__.py file to tests/ to make it a module. Note: These can/should be upstreamed.

 * Add TEST_DEPENDS and test target so that unit tests can be run:

    Ran 16 tests in 36.030s - OK

 * Fix typo in MANIFEST.in causing a warning [1] 

[1] https://github.com/rasbt/pyprind/issues/25
[2] https://github.com/rasbt/pyprind/pull/26
Comment 4 Neel Chauhan freebsd_committer freebsd_triage 2016-03-14 14:34:57 UTC
Created attachment 168149 [details]
Shar file for misc/pyprind 2.9.5

I made the changes and have uploaded a new shar file with the patches.
Comment 5 Neel Chauhan freebsd_committer freebsd_triage 2016-03-14 14:35:35 UTC
Created attachment 168150 [details]
poudriere build log for misc/pyprind 2.9.5 on FreeBSD 10.2
Comment 6 Neel Chauhan freebsd_committer freebsd_triage 2016-03-14 14:35:51 UTC
Created attachment 168151 [details]
poudriere build log for misc/pyprind 2.9.5 on FreeBSD 9.3
Comment 7 Neel Chauhan freebsd_committer freebsd_triage 2016-03-14 15:00:58 UTC
Created attachment 168154 [details]
Shar file for misc/pyprind 2.9.5 with regression test

I am not sure if the regression test actually works, but I attempted to do it here.
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2016-03-15 10:39:18 UTC
@Neel, perhaps i should have been clearer, i had/have made those changes already and wanted to leave feedback here on them. I'll review your update to see if there's anything extra before I commit
Comment 9 Neel Chauhan freebsd_committer freebsd_triage 2016-06-05 13:40:02 UTC
Created attachment 171050 [details]
Shar file for misc/pyprind 2.9.8

New version, posting updated shar files & poudriere build logs
Comment 10 Neel Chauhan freebsd_committer freebsd_triage 2016-06-05 13:41:45 UTC
Created attachment 171051 [details]
Poudriere build log for misc/pyprind 2.9.8 on FreeBSD 10.3 amd64
Comment 11 Neel Chauhan freebsd_committer freebsd_triage 2016-06-05 13:47:07 UTC
Created attachment 171052 [details]
Poudriere build log for misc/pyprind 2.9.8 on FreeBSD 10.3 i386
Comment 12 Neel Chauhan freebsd_committer freebsd_triage 2016-06-05 13:52:58 UTC
Created attachment 171055 [details]
Poudriere build log for misc/pyprind 2.9.8 on FreeBSD 9.3 amd64
Comment 13 Neel Chauhan freebsd_committer freebsd_triage 2016-06-09 12:10:10 UTC
Created attachment 171230 [details]
Shar file for misc/py-pyprind 2.9.8

I decided to change the folder name from pyprind to py-pyprind because I saw many ports which also had a py- prefix despite "py" being in the original name of the port.
Comment 14 Kubilay Kocak freebsd_committer freebsd_triage 2016-06-20 08:34:35 UTC
@Neel, my apologies for the delay Neel, I'll sort (commit) this shortly
Comment 15 Kubilay Kocak freebsd_committer freebsd_triage 2016-06-30 09:07:03 UTC
Landing shortly, pending a few changes:

* Remove obsoleted TESTS option, replace with TEST_DEPENDS and test target
* Modify patch-setup.py to use nosetests (as upstream does) [1]. Remove __init__.py patch accordingly
* Add LICENSE_FILE
* Remove ${PORTSDIR} from *_DEPENDS

[1] https://github.com/rasbt/pyprind/blob/master/ci/.travis_test.sh
Comment 16 Kubilay Kocak freebsd_committer freebsd_triage 2016-06-30 09:10:01 UTC
MASTER_SITES also out-of-order (portlint)
Comment 17 commit-hook freebsd_committer freebsd_triage 2016-06-30 09:14:33 UTC
A commit references this bug:

Author: koobs
Date: Thu Jun 30 09:14:00 UTC 2016
New revision: 417819
URL: https://svnweb.freebsd.org/changeset/ports/417819

Log:
  [NEW] misc/py-pyprind: Python Progress Bar and Percent Indicator Utility

  The PyPrind (Python Progress Indicator) module provides a progress bar
  and a percentage indicator object that let you track the progress of a
  loop structure or other iterative computation. Typical applications
  include the processing of large data sets to provide an intuitive
  estimate at runtime about the progress of the computation.

  WWW: https://www.github.com/rasbt/pyprind

  PR:		207758
  Submitted by:	Neel Chauhan <neel neelc org>

Changes:
  head/misc/Makefile
  head/misc/py-pyprind/
  head/misc/py-pyprind/Makefile
  head/misc/py-pyprind/distinfo
  head/misc/py-pyprind/files/
  head/misc/py-pyprind/files/patch-setup.py
  head/misc/py-pyprind/pkg-descr
Comment 18 Kubilay Kocak freebsd_committer freebsd_triage 2016-06-30 09:15:22 UTC
Committed, with changes. Many apologies for the delay Neel