Created attachment 167963 [details] v0 clang34 (in base) on 10.x systems doesn't support C++14. error: invalid value 'c++14' in '-std=c++14' http://beefy5.nyi.freebsd.org/data/101i386-default/410738/logs/errors/freefilesync-7.9.log futimens/utimensat have only been MFC'd to 10.3 in base r293474. ../../zen/file_access.cpp:893:15: error: no member named 'futimens' in the global namespace if (::futimens(fdFile, newTimes) != 0) ~~^ ../../zen/file_access.cpp:898:15: error: no member named 'utimensat' in the global namespace if (::utimensat(AT_FDCWD, filePath.c_str(), newTimes, AT_SYMLINK_NOFOLLOW) != 0) ~~^ 2 errors generated.
Thanks for the quick fix. Could you commit your patch? Thank you.
I couldn't land as is because Subversion properties are PITA. v0 combines both Unix and DOS line endings which upsets |svn add| but then our style[1] forbids svn:eol-style != native. See review D5607 for proper fix.
A commit references this bug: Author: jbeich Date: Fri Mar 11 07:41:19 UTC 2016 New revision: 410810 URL: https://svnweb.freebsd.org/changeset/ports/410810 Log: mainsysutils/freefilesync: unbreak build on 10.x error: invalid value 'c++14' in '-std=c++14' ../../zen/file_access.cpp:893:15: error: no member named 'futimens' in the global namespace if (::futimens(fdFile, newTimes) != 0) ~~^ ../../zen/file_access.cpp:898:15: error: no member named 'utimensat' in the global namespace if (::utimensat(AT_FDCWD, filePath.c_str(), newTimes, AT_SYMLINK_NOFOLLOW) != 0) ~~^ 2 errors generated. PR: 207879 Reported by: pkg-fallout Approved by: kevlo (maintainer, previous version) Changes: head/sysutils/freefilesync/Makefile head/sysutils/freefilesync/files/patch-zen_file__access.cpp
Of course, git-svn screwed up ^M (carriage-return). Mk/Uses/dos2unix.mk removed svn:eol-style to handle it but regular ports are forbidden to mess with properties (cf. Committer's Guide). Backing out...
A commit references this bug: Author: jbeich Date: Fri Mar 11 08:03:50 UTC 2016 New revision: 410811 URL: https://svnweb.freebsd.org/changeset/ports/410811 Log: sysutils/freefilesync: back out r207879 to fix INDEX bustage PR: 207879 Changes: head/sysutils/freefilesync/Makefile head/sysutils/freefilesync/files/patch-zen_file__access.cpp
A commit references this bug: Author: jbeich Date: Fri Mar 11 08:09:25 UTC 2016 New revision: 410813 URL: https://svnweb.freebsd.org/changeset/ports/410813 Log: sysutils/freefilesync: unbreak build on 10.x (partially r410811) error: invalid value 'c++14' in '-std=c++14' PR: 207879 Reported by: pkg-fallout Approved by: kevlo (maintainer) Changes: head/sysutils/freefilesync/Makefile
Created attachment 167992 [details] simple version (depends on review D5607)
Created attachment 167993 [details] ugly version
Can portmgr advise a better fix or, at least, vote on the version it prefers?
commit D5607, and the simple version, it feels better.
A commit references this bug: Author: jbeich Date: Fri Mar 11 10:42:55 UTC 2016 New revision: 410820 URL: https://svnweb.freebsd.org/changeset/ports/410820 Log: sysutils/freefilesync: unbreak build on 10.x (partially r410810) ../../zen/file_access.cpp:893:15: error: no member named 'futimens' in the global namespace if (::futimens(fdFile, newTimes) != 0) ~~^ ../../zen/file_access.cpp:898:15: error: no member named 'utimensat' in the global namespace if (::utimensat(AT_FDCWD, filePath.c_str(), newTimes, AT_SYMLINK_NOFOLLOW) != 0) ~~^ 2 errors generated. PR: 207879 Reported by: pkg-fallout Approved by: kevlo (maintainer, previous version) Reviewed by: portmgr (mat) Changes: head/sysutils/freefilesync/Makefile head/sysutils/freefilesync/files/patch-zen_file__access.cpp
Thanks for quick response.
A commit references this bug: Author: jbeich Date: Fri Mar 11 11:26:52 UTC 2016 New revision: 410824 URL: https://svnweb.freebsd.org/changeset/ports/410824 Log: sysutils/freefilesync: fixup runtime for DragonFly No PORTREVISION bump as DragonFly build is still broken. PR: 207879 Changes: head/sysutils/freefilesync/files/patch-zen_file__access.cpp