Bug 208302 - editors/codelite: fix clang 3.7, add clang 3.8, fix brief comment support
Summary: editors/codelite: fix clang 3.7, add clang 3.8, fix brief comment support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Mathieu Arnold
URL:
Keywords: easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-03-26 09:32 UTC by Ivan Rozhuk
Modified: 2016-06-21 15:43 UTC (History)
2 users (show)

See Also:

Attachments
Makefile patch (3.27 KB, patch)
2016-03-26 09:32 UTC, Ivan Rozhuk 		no flags Details | Diff
patch fixes issue as well as fixing some QA problems (3.67 KB, patch)
2016-05-31 08:39 UTC, Mahdi Mokhtari 		mmokhi: maintainer-approval+
Details | Diff
Previous patch + liniting fixes + Mathieu's point applied (3.48 KB, patch)
2016-06-15 15:37 UTC, Mahdi Mokhtari 		mmokhi: maintainer-approval+
Details | Diff
Previous patch + liniting fixes + Mathieu's point applied WITHOUT Whitespace edits (3.36 KB, patch)
2016-06-21 09:39 UTC, Mahdi Mokhtari 		mmokhi: maintainer-approval+
Details | Diff
Previous patch + liniting fixes + Mathieu's point applied WITHOUT Whitespace edits (3.23 KB, patch)
2016-06-21 10:21 UTC, Mahdi Mokhtari 		mmokhi: maintainer-approval+
Details | Diff
Previous patch + liniting fixes + Mathieu's point applied WITHOUT Whitespace edits (3.27 KB, patch)
2016-06-21 15:23 UTC, Mahdi Mokhtari 		no flags Details | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2016-03-26 09:32:51 UTC 
Created attachment 168644 [details]
Makefile patch

fix clang 3.7 code completion
add clang 3.8
fix brief comment support
Comment 1 Mahdi Mokhtari freebsd_committer freebsd_triage 2016-05-31 08:39:05 UTC 
Created attachment 170851 [details]
patch fixes issue as well as fixing some QA problems

QA: done
poudriere Okay
portlint Okay
Comment 2 Mahdi Mokhtari freebsd_committer freebsd_triage 2016-05-31 08:40:39 UTC 
I think it's ready to committed in.
DeAssiging from myself so that a committer comes and takes this :)
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2016-06-12 11:39:13 UTC 
All the patch could be folded into one command patching two files.
Comment 4 Mahdi Mokhtari freebsd_committer freebsd_triage 2016-06-12 12:17:57 UTC 
(In reply to Mathieu Arnold from comment #3)
You're talking about OPTIONS_RADIO_CLANG3[4 5 6] ?
You mean it'd better not to use radio options, but to patch files in all cases ?
Comment 5 Mathieu Arnold freebsd_committer freebsd_triage 2016-06-15 10:48:22 UTC 
Ah, no, I mean you're doing:
 post-patch-CLANG35-on:
 	@${REINPLACE_CMD} -e \
 		's|/usr/lib/llvm-.*/|${LOCALBASE}/llvm35/|' \
 		${WRKSRC}/cmake/Modules/FindLibClang.cmake
+	@${REINPLACE_CMD} -e \
+		's|/usr/lib/llvm-.*/|${LOCALBASE}/llvm35/|' \
+		${WRKSRC}/cmake/Modules/FindLibLLDB.cmake

You could do:

 post-patch-CLANG35-on:
 	@${REINPLACE_CMD} -e \
 		's|/usr/lib/llvm-.*/|${LOCALBASE}/llvm35/|' \
- 		${WRKSRC}/cmake/Modules/FindLibClang.cmake
+ 		${WRKSRC}/cmake/Modules/FindLibClang.cmake \
+		${WRKSRC}/cmake/Modules/FindLibLLDB.cmake

Only one SED for two files.
Comment 6 Mahdi Mokhtari freebsd_committer freebsd_triage 2016-06-15 15:37:00 UTC 
Created attachment 171464 [details]
Previous patch + liniting fixes + Mathieu's point applied

(In reply to Mathieu Arnold from comment #5)
Thanks Mathieu, Done ;)
Comment 7 Mahdi Mokhtari freebsd_committer freebsd_triage 2016-06-21 09:39:46 UTC 
Created attachment 171638 [details]
Previous patch + liniting fixes + Mathieu's point applied WITHOUT Whitespace edits

To clarify exactly what is this patch doing (only one clear job per patch), I deleted white-space correcting parts from previous patch.
Comment 8 Mahdi Mokhtari freebsd_committer freebsd_triage 2016-06-21 10:21:34 UTC 
Created attachment 171641 [details]
Previous patch + liniting fixes + Mathieu's point applied WITHOUT Whitespace edits
Comment 9 Mahdi Mokhtari freebsd_committer freebsd_triage 2016-06-21 15:23:04 UTC 
Created attachment 171649 [details]
Previous patch + liniting fixes + Mathieu's point applied WITHOUT Whitespace edits

Correcting a typo (dup-string in cmake args)
Comment 10 commit-hook freebsd_committer freebsd_triage 2016-06-21 15:43:11 UTC 
A commit references this bug:

Author: mat
Date: Tue Jun 21 15:43:00 UTC 2016
New revision: 417275
URL: https://svnweb.freebsd.org/changeset/ports/417275

Log:
  fix clang 3.7, add clang 3.8, fix brief comment support [1]

  While there, refactor the CLANGXX options.

  PR:		208302 [1]
  Submitted by:	maintainer, rozhuk im gmail com
  Sponsored by:	Absolight

Changes:
  head/editors/codelite/Makefile
Comment 11 Mathieu Arnold freebsd_committer freebsd_triage 2016-06-21 15:43:38 UTC 
Committed with some refactoring.