Bug 208309 - lang/gcc: convert to CONFIGURE_OUTSOURCE
Summary: lang/gcc: convert to CONFIGURE_OUTSOURCE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords:
Depends on: 208294
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-26 15:53 UTC by Jan Beich
Modified: 2016-04-13 10:44 UTC (History)
1 user (show)

See Also:
gerald: maintainer-feedback+


Attachments
v0 (1.24 KB, patch)
2016-03-26 15:53 UTC, Jan Beich
jbeich: maintainer-approval? (gerald)
Details | Diff
missed (479 bytes, patch)
2016-03-26 21:44 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2016-03-26 15:53:28 UTC
Created attachment 168655 [details]
v0

Once bug 208294 lands make it slightly more obvious the port builds outside of source tree.
Comment 1 Gerald Pfeifer freebsd_committer freebsd_triage 2016-03-26 18:47:08 UTC
This is a nice simplification!

Approved for lang/gcc and the other lang/gcc* ports (and I recommend 
to at least cover lang/gcc5* and lang/gcc6*) once the infrastructure
is in _AND_ the build directory is NOT a subdirectory of the source
directory.

Cf. https://gcc.gnu.org/install/configure.html which says

  "building where objdir is a subdirectory of srcdir is unsupported".
Comment 2 Jan Beich freebsd_committer freebsd_triage 2016-03-26 21:44:17 UTC
Created attachment 168662 [details]
missed

Additional changes missed in v0.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-04-13 10:41:26 UTC
A commit references this bug:

Author: jbeich
Date: Wed Apr 13 10:40:59 UTC 2016
New revision: 413188
URL: https://svnweb.freebsd.org/changeset/ports/413188

Log:
  lang/gcc*: convert to CONFIGURE_OUTSOURCE

  PR:		208294, 208309
  Exp-run by:	antoine
  Approved by:	gerald (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D4157

Changes:
  head/lang/gcc/Makefile
  head/lang/gcc46/Makefile
  head/lang/gcc47/Makefile
  head/lang/gcc48/Makefile
  head/lang/gcc49/Makefile
  head/lang/gcc5/Makefile
  head/lang/gcc5-devel/Makefile
  head/lang/gcc6-devel/Makefile