Bug 208456 - [MAINTAINER][PATCH] multimedia/kodi: update to 16.0
Summary: [MAINTAINER][PATCH] multimedia/kodi: update to 16.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: needs-qa, patch
Depends on: 208161
Blocks:
  Show dependency treegraph
 
Reported: 2016-04-01 16:20 UTC by mickael.maillot
Modified: 2016-04-16 18:11 UTC (History)
3 users (show)

See Also:
mickael.maillot: maintainer-feedback+


Attachments
kodi 16.0 diff update (113.18 KB, text/plain)
2016-04-01 16:20 UTC, mickael.maillot
no flags Details
Makefile.svnpatch.rej (1.85 KB, text/x-reject)
2016-04-01 17:56 UTC, Mikael Urankar
no flags Details
kodi 16 update (112.79 KB, patch)
2016-04-01 18:18 UTC, Mikael Urankar
no flags Details | Diff
patch updated with plist fix (139.53 KB, patch)
2016-04-05 16:16 UTC, mickael.maillot
mickael.maillot: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mickael.maillot 2016-04-01 16:20:23 UTC
Created attachment 168873 [details]
kodi 16.0 diff update

Hi,

Update ready to go !
some infos:
- pulseaudio removed from default option: because otherwise kodi will select pulseaudio first and it's really not needed.
- texturepacker disabled: because it's so heavily broken in upstream. not really important. it will be back in 17.0 with the new cmake build system.
- switch to swig3, like all linux distrib (no change)
- this port need libcec 3.1 ! PR208161
- hudge patch for arm (and rbpi2) support will follow
- i'm currently working on a port for the 20+ binary addons

poudriere logs:
http://fneu.fr/freebsd/kodi/
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2016-04-01 17:56:40 UTC
Created attachment 168878 [details]
Makefile.svnpatch.rej

Hi,

Your patch doesn't apply cleanly, it seems it was generated against r411990
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2016-04-01 18:18:57 UTC
Created attachment 168879 [details]
kodi 16 update

I'm attaching a patch that applies cleanly with ports at r412348
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2016-04-04 14:28:46 UTC
there is a plist issue:

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%DATADIR%%/system/keyboardlayouts/french.xml
Comment 4 mickael.maillot 2016-04-05 16:16:54 UTC
Created attachment 169010 [details]
patch updated with plist fix

Sorry for the plist entry missing.
Comment 5 Bartek Rutkowski freebsd_committer freebsd_triage 2016-04-10 13:51:01 UTC
This patch fails to build with:

"
=======================<phase: configure      >============================
===>   py27-icalendar-3.9.2 depends on package: py27-setuptools27>0 - found
===>   py27-icalendar-3.9.2 depends on file: /usr/local/bin/python2.7 - found
===>   py27-icalendar-3.9.2 depends on file: /usr/local/bin/ccache - found
===>  Configuring for py27-icalendar-3.9.2
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "setup.py", line 67
    test_suite='icalendar.tests'
SyntaxError: keyword argument repeated
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/py-icalendar
"

You can see the full buildlog here: http://pd.valinor.palantiri.org/data/latest-per-pkg/py27-icalendar/3.9.2/11amd64-default.log
Can you please test it and provide a fixed patch?
Comment 6 Bartek Rutkowski freebsd_committer freebsd_triage 2016-04-10 13:52:30 UTC
(In reply to Bartek Rutkowski from comment #5)
Sorry, wrong PR, the above comment was meant for #208671.
Comment 7 Bartek Rutkowski freebsd_committer freebsd_triage 2016-04-10 14:01:50 UTC
The latest patch doesnt apply cleanly, there's 'Oops.rej' file created after applying against r412954.
Comment 8 commit-hook freebsd_committer freebsd_triage 2016-04-16 18:09:05 UTC
A commit references this bug:

Author: riggs
Date: Sat Apr 16 18:08:59 UTC 2016
New revision: 413474
URL: https://svnweb.freebsd.org/changeset/ports/413474

Log:
  Update to upstream version 16.0

  Detailed maintainer log:
  - pulseaudio removed from default option: because otherwise kodi will select
    pulseaudio first and it's really not needed.
  - texturepacker disabled: because it's so heavily broken in upstream. not
    really important. it will be back in 17.0 with the new cmake build system.
  - switch to swig3, like all linux distrib (no change)

  PR:		208456
  Submitted by:	mickael.maillot@gmail.com (maintainer)

Changes:
  head/multimedia/kodi/Makefile
  head/multimedia/kodi/distinfo
  head/multimedia/kodi/files/patch-Makefile.include.in
  head/multimedia/kodi/files/patch-clang
  head/multimedia/kodi/files/patch-configure.ac
  head/multimedia/kodi/files/patch-ffmpegx86
  head/multimedia/kodi/files/patch-freebsd
  head/multimedia/kodi/files/patch-lib_cpluff_autogen.sh
  head/multimedia/kodi/files/patch-lib_cpluff_configure.ac
  head/multimedia/kodi/files/patch-lib_cximage-6.0_raw_dcraw.c
  head/multimedia/kodi/files/patch-tools__depends__target__ffmpeg__autobuild.sh
  head/multimedia/kodi/files/patch-tools_depends_target_ffmpeg_FFmpeg-2.8.6-Jarvis-16.0_libavutil_x86_asm.h
  head/multimedia/kodi/files/patch-tools_depends_target_ffmpeg_Makefile
  head/multimedia/kodi/files/patch-tools_depends_target_ffmpeg_autobuild.sh
  head/multimedia/kodi/files/patch-xbmc_LangInfo.cpp
  head/multimedia/kodi/files/patch-xbmc__LangInfo.cpp
  head/multimedia/kodi/files/patch-xbmc__cores__dvdplayer__DVDDemuxSPU.cpp
  head/multimedia/kodi/files/patch-xbmc__dialogs__GUIDialogGamepad.cpp
  head/multimedia/kodi/files/patch-xbmc__dialogs__GUIDialogNumeric.cpp
  head/multimedia/kodi/files/patch-xbmc__guilib__GUIAction.cpp
  head/multimedia/kodi/files/patch-xbmc__guilib__GUISpinControl.cpp
  head/multimedia/kodi/files/patch-xbmc__guilib__TextureBundleXPR.h
  head/multimedia/kodi/files/patch-xbmc__guilib__XBTF.h
  head/multimedia/kodi/files/patch-xbmc__interfaces__legacy__Dialog.cpp
  head/multimedia/kodi/files/patch-xbmc__linux__XFileUtils.cpp
  head/multimedia/kodi/files/patch-xbmc__main__main.cpp
  head/multimedia/kodi/files/patch-xbmc__pvr__PVRActionListener.cpp
  head/multimedia/kodi/files/patch-xbmc__settings__AdvancedSettings.cpp
  head/multimedia/kodi/files/patch-xbmc__storage__linux__DeviceKitDisksProvider.cpp
  head/multimedia/kodi/files/patch-xbmc__storage__linux__UDisksProvider.cpp
  head/multimedia/kodi/files/patch-xbmc__threads__platform__pthreads__ThreadImpl.cpp
  head/multimedia/kodi/files/patch-xbmc__utils__CharsetConverter.cpp
  head/multimedia/kodi/files/patch-xbmc__windowing__WinEventsX11.cpp
  head/multimedia/kodi/files/patch-xbmc_cores_AudioEngine_Sinks_AESinkOSS.cpp
  head/multimedia/kodi/files/patch-xbmc_cores_dvdplayer_DVDDemuxSPU.cpp
  head/multimedia/kodi/files/patch-xbmc_dialogs_GUIDialogGamepad.cpp
  head/multimedia/kodi/files/patch-xbmc_dialogs_GUIDialogNumeric.cpp
  head/multimedia/kodi/files/patch-xbmc_guilib_GUIAction.cpp
  head/multimedia/kodi/files/patch-xbmc_guilib_GUISpinControl.cpp
  head/multimedia/kodi/files/patch-xbmc_guilib_TextureBundleXPR.h
  head/multimedia/kodi/files/patch-xbmc_guilib_XBTF.h
  head/multimedia/kodi/files/patch-xbmc_interfaces_builtins_GUIContainerBuiltins.cpp
  head/multimedia/kodi/files/patch-xbmc_interfaces_builtins_WeatherBuiltins.cpp
  head/multimedia/kodi/files/patch-xbmc_interfaces_legacy_Dialog.cpp
  head/multimedia/kodi/files/patch-xbmc_linux_XFileUtils.cpp
  head/multimedia/kodi/files/patch-xbmc_main_main.cpp
  head/multimedia/kodi/files/patch-xbmc_music_tags_MusicInfoTagLoaderCDDA.cpp
  head/multimedia/kodi/files/patch-xbmc_pvr_PVRActionListener.cpp
  head/multimedia/kodi/files/patch-xbmc_pvr_recordings_PVRRecording.cpp
  head/multimedia/kodi/files/patch-xbmc_settings_AdvancedSettings.cpp
  head/multimedia/kodi/files/patch-xbmc_storage_linux_DeviceKitDisksProvider.cpp
  head/multimedia/kodi/files/patch-xbmc_storage_linux_UDisksProvider.cpp
  head/multimedia/kodi/files/patch-xbmc_threads_platform_pthreads_ThreadImpl.cpp
  head/multimedia/kodi/files/patch-xbmc_utils_CharsetConverter.cpp
  head/multimedia/kodi/files/patch-xbmc_windowing_WinEventsX11.cpp
  head/multimedia/kodi/pkg-plist