Bug 208855 - mail/thunderbird: Fail to build when LIBPROXY option is enabled
Summary: mail/thunderbird: Fail to build when LIBPROXY option is enabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gecko (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-17 10:01 UTC by Ting-Wei Lan
Modified: 2016-04-25 16:27 UTC (History)
2 users (show)

See Also:


Attachments
Thunderbird 45.0 build log on FreeBSD 10 (721.76 KB, text/plain)
2016-04-17 10:01 UTC, Ting-Wei Lan
no flags Details
patch-thunderbird-nsLibProxySettings_cpp (292 bytes, patch)
2016-04-25 02:09 UTC, w.schwarzenfeld
jbeich: maintainer-approval-
Details | Diff
patch-libxul-nsLibProxySettings_cpp (278 bytes, patch)
2016-04-25 02:09 UTC, w.schwarzenfeld
no flags Details | Diff
patch-libxul-nsLibProxySettings_cpp (276 bytes, patch)
2016-04-25 04:05 UTC, w.schwarzenfeld
no flags Details | Diff
poudriere-thunderbird-success.log (162.88 KB, application/x-bzip)
2016-04-25 10:30 UTC, w.schwarzenfeld
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2016-04-17 10:01:55 UTC
Created attachment 169393 [details]
Thunderbird 45.0 build log on FreeBSD 10

Please see the attached build log. The most important error message is:

/wrkdirs/usr/ports/mail/thunderbird/work/thunderbird-45.0/mozilla/toolkit/system/unixproxy/nsLibProxySettings.cpp:129:5: error: use of undeclared identifier 'NS_SYSTEMPROXYSETTINGS_CONTRACTID'
  { NS_SYSTEMPROXYSETTINGS_CONTRACTID, &kNS_UNIXSYSTEMPROXYSERVICE_CID },
    ^
2 warnings and 1 error generated.
/wrkdirs/usr/ports/mail/thunderbird/work/thunderbird-45.0/mozilla/config/rules.mk:956: recipe for target 'nsLibProxySettings.o' failed
gmake[5]: *** [nsLibProxySettings.o] Error 1
Comment 1 Ting-Wei Lan 2016-04-22 03:28:45 UTC
The same problem also happens when building www/libxul.
Comment 2 w.schwarzenfeld 2016-04-25 01:49:13 UTC
mail/thunderbird/work/thunderbird-45.0/mozilla/toolkit/system/unixproxy/nsLibProxySettings.cpp
misses
#include "nsNetUtil.h"

same for

www/libxul/work/firefox-45.1.0esr/toolkit/system/unixproxy/nsLibProxySettings.cpp
Comment 3 w.schwarzenfeld 2016-04-25 02:09:03 UTC
Created attachment 169646 [details]
patch-thunderbird-nsLibProxySettings_cpp
Comment 4 w.schwarzenfeld 2016-04-25 02:09:45 UTC
Created attachment 169647 [details]
patch-libxul-nsLibProxySettings_cpp
Comment 5 w.schwarzenfeld 2016-04-25 04:05:59 UTC
Created attachment 169648 [details]
patch-libxul-nsLibProxySettings_cpp

Correct it.
Comment 6 w.schwarzenfeld 2016-04-25 10:30:41 UTC
Created attachment 169668 [details]
poudriere-thunderbird-success.log
Comment 7 Jan Beich freebsd_committer freebsd_triage 2016-04-25 13:30:33 UTC
Comment on attachment 169646 [details]
patch-thunderbird-nsLibProxySettings_cpp

nsNetUtil.h line was removed intentionally. Better use upstream fix, so it can be dropped later.
https://hg.mozilla.org/mozilla-central/rev/cf774875a1f4
https://hg.mozilla.org/mozilla-central/rev/23226470bb94
Comment 8 commit-hook freebsd_committer freebsd_triage 2016-04-25 16:19:37 UTC
A commit references this bug:

Author: jbeich
Date: Mon Apr 25 16:19:14 UTC 2016
New revision: 414020
URL: https://svnweb.freebsd.org/changeset/ports/414020

Log:
  gecko: unbreak build with LIBPROXY=on

  PR:		208855
  Reported by:	Ting-Wei Lan, Walter Schwarzenfeld
  Submitted by:	cmt via r401981

Changes:
  head/mail/thunderbird/files/patch-bug1243312
  head/www/firefox/files/patch-bug1243312
  head/www/firefox/files/patch-toolkit_system_unixproxy_nsLibProxySettings.cpp
  head/www/firefox-esr/files/patch-bug1243312
  head/www/libxul/files/patch-bug1243312
  head/www/seamonkey/files/patch-bug1243312
  head/www/seamonkey/files/patch-toolkit_system_unixproxy_nsLibProxySettings.cpp
Comment 9 commit-hook freebsd_committer freebsd_triage 2016-04-25 16:27:40 UTC
A commit references this bug:

Author: jbeich
Date: Mon Apr 25 16:26:46 UTC 2016
New revision: 414021
URL: https://svnweb.freebsd.org/changeset/ports/414021

Log:
  MFH: r414020

  gecko: unbreak build with LIBPROXY=on

  PR:		208855
  Reported by:	Ting-Wei Lan, Walter Schwarzenfeld
  Submitted by:	cmt via r401981
  Approved by:	ports-secteam "build fix" blanket

Changes:
_U  branches/2016Q2/
  branches/2016Q2/mail/thunderbird/files/patch-bug1243312
  branches/2016Q2/www/firefox/files/patch-bug1243312
  branches/2016Q2/www/firefox/files/patch-toolkit_system_unixproxy_nsLibProxySettings.cpp
  branches/2016Q2/www/firefox-esr/files/patch-bug1243312
  branches/2016Q2/www/libxul/files/patch-bug1243312
  branches/2016Q2/www/seamonkey/files/patch-bug1243312
  branches/2016Q2/www/seamonkey/files/patch-toolkit_system_unixproxy_nsLibProxySettings.cpp