Created attachment 169791 [details] patch - Update to 0.12.1. - Enable DBUS option by default. Desktop systems almost always have DBus installed. - Enable UPNP option by default. Many ISP supplied modems contain a NAT these days. - Remove --disable-reduce-exports. It's disabled by default.
I have no major problems with the decisions made here. I have not done any research on ZeroMQ, so can't really comment on these. I question default UPNP, as that package, to my knowledge, still comes with a 'don't install this' warning. I also favor putting bitcoin-bench under the test, instead of eliminating it entirely: but I wouldn't mind either way. Lastly, any reason why you didn't choose to follow upstream onto QT5? That is what I have done in my work in progress?
Created attachment 169811 [details] patch2 I can't find any warning in net/miniupnpc so I left UPNP enabled by default. The option only makes UPnP available. Users still need to configure bitcoin to use it. Moved bench-bitcoin under TESTS option. As long as we're stuck with KDE4 I think it's better for applications to keep using Qt4.
Created attachment 169840 [details] Patch to upgrade to 0.12.1, add rc.d script file Thanks, this passes all my tests, so I approve it. I have also added in the bitcoind rc.d script from bug 208937.
A commit references this bug: Author: tijl Date: Sun May 1 09:50:44 UTC 2016 New revision: 414405 URL: https://svnweb.freebsd.org/changeset/ports/414405 Log: - Update net-p2p/bitcoin to 0.12.1. - Enable DBUS option by default. Desktop systems almost always have DBus installed. - Enable UPNP option by default. Many ISP supplied modems contain a NAT these days. - Remove --disable-reduce-exports. It's disabled by default. - Add bitcoind rc.d script. [1] PR: 208937, 209136 Submitted by: xenophon+fbsdports@irtnog.org [1] Approved by: robbak@gmail.com (maintainer) Changes: head/net-p2p/bitcoin/Makefile head/net-p2p/bitcoin/distinfo head/net-p2p/bitcoin/files/bitcoind.in head/net-p2p/bitcoin-daemon/Makefile head/net-p2p/bitcoin-utils/Makefile